-
-
Notifications
You must be signed in to change notification settings - Fork 364
refactor(Dropdown): update dark style #5711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request focuses on updating the dark theme styles for the dropdown component. It introduces a new scss variable for the dark theme background color and includes the corresponding scss file to apply the new styles. Additionally, the project version was adjusted. Updated class diagram for Dropdown stylesclassDiagram
class Dropdown {
---
string BackgroundColor
---
+UpdateBackgroundColor(string color)
}
note for Dropdown "Added dark theme styling for dropdown menus"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using CSS variables directly in
bootstrapblazor-dark.scssinstead of defining new variables like$bs-dropdown-bg-dark. - It's unusual to downgrade the project version in a feature PR; is this intentional?
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5711 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 657 657
Lines 29824 29824
Branches 4226 4226
=========================================
Hits 29824 29824 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #5710
Summary By Copilot
This pull request includes several changes to the BootstrapBlazor project, focusing on version adjustments and theme updates for dropdown components. The most important changes are listed below:
Version Adjustment:
src/BootstrapBlazor/BootstrapBlazor.csproj: Downgraded the project version from9.5.0-beta15to9.4.12.Theme Updates:
src/BootstrapBlazor/Components/Dropdown/Dropdown.razor.scss: Added dark theme styling for dropdown menus.src/BootstrapBlazor/wwwroot/scss/bootstrapblazor-dark.scss: Introduced a new variable$bs-dropdown-bg-darkfor dark theme dropdown background color.src/BootstrapBlazor/wwwroot/scss/components.scss: Included theDropdown.razor.scssfile to ensure the new dropdown styles are imported.Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Updates the dropdown component to support dark theme styling by introducing a new CSS variable and applying it when the dark theme is active.
Enhancements:
$bs-dropdown-bg-darkfor dark theme dropdown background color.Dropdown.razor.scssfile to ensure the new dropdown styles are imported.