Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Mar 25, 2025

Link issues

fixes #5714

Summary By Copilot

This pull request focuses on consolidating and simplifying the GitHub workflows related to issue management by replacing two existing workflows with a single, more efficient workflow.

Consolidation and simplification of workflows:

  • Added a new workflow .github/workflows/close-stale-issues.yml to handle closing inactive issues. This workflow runs daily and uses the actions/stale action to mark issues as stale and close them if there is no response within 2 days.
  • Removed the .github/workflows/issue-check-inactive.yml workflow, which previously checked for inactive issues every 15 days and labeled them as inactive if there was no response within 3 days.
  • Removed the .github/workflows/issue-close-required.yml workflow, which previously closed issues labeled with need-repro-project if there was no response within 2 days.

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Consolidates and simplifies GitHub workflows related to issue management by replacing two existing workflows with a single, more efficient workflow to close stale issues.

CI:

  • Replaces the issue-check-inactive and issue-close-required workflows with a single workflow.
  • Adds a new workflow to close issues labeled with need-repro-project or invalid after 2 days of inactivity.
  • Removes the issue-check-inactive workflow, which checked for inactive issues every 15 days.
  • Removes the issue-close-required workflow, which closed issues labeled with need-repro-project.

@bb-auto bb-auto bot added the chore This are tasks or bot action label Mar 25, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Mar 25, 2025

Reviewer's Guide by Sourcery

This pull request consolidates issue management workflows by introducing a new workflow to automatically close stale issues and removing two redundant workflows. The new workflow uses the actions/stale action to identify and close issues that have been inactive for 2 days after being labeled as invalid or need-repro-project.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Introduces a new workflow to automatically close stale issues.
  • Adds a new workflow file to handle closing inactive issues.
  • Configures the workflow to run daily.
  • Utilizes the actions/stale action to identify and close stale issues.
  • Sets a 2-day inactivity threshold for issues labeled as invalid or need-repro-project before closing them.
.github/workflows/close-stale-issues.yml
Removes redundant workflows for issue management.
  • Removes the workflow that checked for inactive issues and labeled them.
  • Removes the workflow that closed issues labeled with need-repro-project.
.github/workflows/issue-check-inactive.yml
.github/workflows/issue-close-required.yml

Assessment against linked issues

Issue Objective Addressed Explanation
#5714 Implement an action to automatically close issues.
#5714 Consolidate and simplify GitHub workflows related to issue management.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added this to the v9.4.0 milestone Mar 25, 2025
@ArgoZhang ArgoZhang merged commit 4d5f9ad into main Mar 25, 2025
3 checks passed
@ArgoZhang ArgoZhang deleted the chore-action branch March 25, 2025 08:27
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a comment to the new workflow file explaining why the previous two workflows were consolidated.
  • It might be helpful to include the labels invalid and need-repro-project in the workflow name or description for clarity.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (788723b) to head (b5a9f67).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #5715   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          657       657           
  Lines        29824     29824           
  Branches      4226      4226           
=========================================
  Hits         29824     29824           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore This are tasks or bot action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(Action): add auto close issue action

2 participants