feat(Tab): add navigation hover style #5718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's Guide by SourceryThis pull request improves the Tab component by adding a navigation hover style to the navigator buttons and updating the ContextMenuItem icons to use the Sequence diagram for Tab navigation button clicksequenceDiagram
participant User
participant Tab Component
participant TabItem
User->>Tab Component: Clicks navigation button
activate Tab Component
Tab Component->>Tab Component: Determines next/previous tab
Tab Component->>TabItem: Activates TabItem
activate TabItem
TabItem-->>Tab Component: Renders content
deactivate TabItem
Tab Component-->>User: Updates UI
deactivate Tab Component
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- The introduction of
nav-link-bar-buttonadds complexity; consider if the hover effect can be achieved without the extra div. - Be consistent with the naming of the scss classes - prefer kebab-case.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Member
Author
|
@sourcery-ai review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5718 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 657 657
Lines 29824 29830 +6
Branches 4226 4229 +3
=========================================
+ Hits 29824 29830 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a comment to explain the purpose of the
nav-link-bar-buttonclass. - The new tooltip properties should be added to the Chinese localization files.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #5717
Summary By Copilot
This pull request includes several updates to the
BootstrapBlazorproject, focusing on updating dependencies, refining UI components, and improving localization.Dependency updates:
src/BootstrapBlazor.Server/BootstrapBlazor.Server.csproj: Updated theBootstrapBlazor.TableExportpackage to version9.2.2.UI improvements:
src/BootstrapBlazor.Server/Components/Samples/Tabs.razor: UpdatedContextMenuItemicons to use thefa-fwclass for consistent icon alignment.src/BootstrapBlazor/Components/Tab/Tab.razor: Enhanced thenav-link-barelements with nestednav-link-bar-buttondivs for better button styling and added hover effects. [1] [2] [3] [4]Localization:
src/BootstrapBlazor.Server/Locales/en-US.json: Corrected the text for theShowColumnListAttrkey to "Show Column show/hide control buttons".Styling enhancements:
src/BootstrapBlazor/Components/Tab/Tab.razor.scss: Added styles for thenav-link-barandnav-link-bar-buttonclasses to improve the appearance and user interaction of tab navigation buttons. [1] [2]Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Improves the Tab component by adding hover styles to the navigation buttons, providing visual feedback on interaction. It also adds tooltips to the navigation buttons and updates the TableExport package version.
Enhancements:
Tests: