Skip to content

refactor(Table): throw exception when set IsTree to true in virtualize mode #5723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 26, 2025
Merged

refactor(Table): throw exception when set IsTree to true in virtualize mode #5723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da189b5
refactor: 增加约束
ArgoZhang Mar 26, 2025
b8700b7
test: 更新单元测试
ArgoZhang Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/BootstrapBlazor/Components/Table/Table.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -909,6 +909,11 @@ protected override void OnParametersSet()
{
base.OnParametersSet();

if (ScrollMode == ScrollMode.Virtual && IsTree)
{
throw new InvalidOperationException($"{GetType()} does not support virtual scrolling in tree mode. ${GetType()} 目前不支持虚拟滚动模式下设置 IsTree=\"true\"");
}

OnInitParameters();

if (Items != null && OnQueryAsync != null)
Expand Down
8 changes: 8 additions & 0 deletions test/UnitTest/Components/TableTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2693,6 +2693,7 @@ public void ScrollMode_Ok()
var localizer = Context.Services.GetRequiredService<IStringLocalizer<Foo>>();
var cut = Context.RenderComponent<BootstrapBlazorRoot>(pb =>
{
pb.Add(a => a.EnableErrorLogger, false);
pb.AddChildContent<Table<Foo>>(pb =>
{
pb.Add(a => a.RenderMode, TableRenderMode.Table);
Expand All @@ -2710,6 +2711,13 @@ public void ScrollMode_Ok()
});
var virtualComponent = cut.FindComponent<Virtualize<Foo>>();
Assert.NotNull(virtualComponent);

var table = cut.FindComponent<Table<Foo>>();
var exception = Assert.Throws<InvalidOperationException>(() => table.SetParametersAndRender(pb =>
{
pb.Add(a => a.IsTree, true);
}));
Assert.NotNull(exception);
}

[Fact]
Expand Down