-
-
Notifications
You must be signed in to change notification settings - Fork 364
fix(Table): column list overflow when too many drop items are present #5725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request addresses an overflow issue in the Table component's column list dropdown when there are too many items. It introduces No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- It might be helpful to add a comment explaining why
overflow: autois necessary.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5725 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 657 657
Lines 29832 29832
Branches 4230 4230
=========================================
Hits 29832 29832 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #5724
Summary By Copilot
This pull request includes a minor change to the
Table.razor.scssfile. The change adds an overflow property to the.table-toolbar .dropdown-menuclass to improve the handling of content that exceeds the maximum height.src/BootstrapBlazor/Components/Table/Table.razor.scss: Addedoverflow: auto;to the.table-toolbar .dropdown-menuclass to handle content overflow.Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add overflow handling to table toolbar dropdown menu to improve usability when many drop items are present
Bug Fixes:
Enhancements: