-
-
Notifications
You must be signed in to change notification settings - Fork 364
feat(Table): add OverscanCount parameter #5730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request introduces the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a range check to the
OverscanCountparameter to prevent unexpected behavior with very large or negative values. - Good job including a unit test for the new
OverscanCountparameter.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5730 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 657 657
Lines 29832 29833 +1
Branches 4230 4230
=========================================
+ Hits 29832 29833 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #5729
Summary By Copilot
This pull request includes several changes to the
BootstrapBlazorproject, focusing on improving the table component's functionality and fixing a minor typo in the localization file. The most important changes include adding a new parameter for virtual scrolling, updating the table component to use this parameter, and making minor code improvements.Enhancements to the table component:
src/BootstrapBlazor/Components/Table/Table.razor: Updated theVirtualizecomponent to use the newOverscanCountparameter for better control over virtual scrolling.src/BootstrapBlazor/Components/Table/Table.razor.cs: Introduced a newOverscanCountparameter with a default value of 10, which allows users to set the overscan count for virtual scrolling.test/UnitTest/Components/TableTest.cs: Added a test case to ensure theOverscanCountparameter is correctly set and used in the table component.Minor code improvements:
src/BootstrapBlazor/Components/Table/Table.razor.TreeNode.cs: Removed unnecessary[NotNull]attribute from theTreeRowsproperty and added a missing newline for better code readability. [1] [2]Localization fix:
src/BootstrapBlazor.Server/Locales/en-US.json: Corrected a typo by changing "UniverIcons" to "UniverIcon".Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add OverscanCount parameter to improve virtual scrolling control in the Table component
New Features:
Bug Fixes:
Enhancements:
Tests: