doc(Tab): update context menu documentation #5741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's Guide by SourceryThis pull request introduces new attributes and localization entries related to the tab context menu functionality. It adds attributes to the Updated class diagram for the Layout componentclassDiagram
class Layout {
+bool ShowTabContextMenu
+RenderFragment BeforeTabContextMenuTemplate
+RenderFragment TabContextMenuTemplate
+string? TabContextMenuRefreshIcon
+string? TabContextMenuCloseIcon
+string? TabContextMenuCloseOtherIcon
+string? TabContextMenuCloseAllIcon
+Func<TabItem, Task<bool>> OnBeforeShowContextMenu
}
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the documentation and component attribute definitions for the tab context menu functionality in BootstrapBlazor. Key changes include the addition of new attributes to the Tab and Layout components, updates to the Tabs component markup to incorporate a fullscreen context menu, and corresponding localization updates in both English and Chinese.
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/BootstrapBlazor.Server/Components/Samples/Tabs.razor.cs | Adds multiple attribute definitions for the Tab component |
| src/BootstrapBlazor.Server/Components/Samples/Tabs.razor | Updates the Tab component usage to include a new fullscreen context menu |
| src/BootstrapBlazor.Server/Components/Samples/Layouts.razor.cs | Adds new attribute definitions for the Layout component |
Files not reviewed (2)
- src/BootstrapBlazor.Server/Locales/en-US.json: Language not supported
- src/BootstrapBlazor.Server/Locales/zh-CN.json: Language not supported
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a brief description of the new attributes to the component's documentation page.
- Ensure the new localization keys follow the existing naming conventions.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5741 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 657 657
Lines 29923 29923
Branches 4245 4245
=========================================
Hits 29923 29923 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #5740
Summary By Copilot
This pull request introduces several new attributes and localization entries related to the tab context menu functionality in the
BootstrapBlazorproject. The most significant changes include the addition of new attributes to theLayoutandTabcomponents, updates to theTabs.razorfile to support the new attributes, and localization updates in both English and Chinese.New attributes for
LayoutandTabcomponents:src/BootstrapBlazor.Server/Components/Samples/Layouts.razor.cs: Added attributes likeShowTabContextMenu,BeforeTabContextMenuTemplate,TabContextMenuTemplate,TabContextMenuRefreshIcon,TabContextMenuCloseIcon,TabContextMenuCloseOtherIcon,TabContextMenuCloseAllIcon, andOnBeforeShowContextMenuto theLayoutcomponent.src/BootstrapBlazor.Server/Components/Samples/Tabs.razor.cs: Added attributes likeShowContextMenu,ContextMenuRefreshIcon,ContextMenuCloseIcon,ContextMenuCloseOtherIcon,ContextMenuCloseAllIcon,ContextMenuFullScreenIcon, andOnBeforeShowContextMenuto theTabcomponent.Updates to
Tabs.razor:src/BootstrapBlazor.Server/Components/Samples/Tabs.razor: Added theShowContextMenuFullScreenattribute to theTabcomponent.Localization updates:
src/BootstrapBlazor.Server/Locales/en-US.json: Added new localization entries for the tab context menu attributes in English. [1] [2]src/BootstrapBlazor.Server/Locales/zh-CN.json: Added new localization entries for the tab context menu attributes in Chinese. [1] [2]Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Update documentation and attributes for tab context menu functionality in the BootstrapBlazor project
New Features:
Enhancements:
Documentation: