-
-
Notifications
You must be signed in to change notification settings - Fork 364
feat(Mask): update opacity to 0.3 #5747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request modifies the CSS styling for mask components in the BootstrapBlazor library. The changes involve updating the opacity of the mask and backdrop by introducing and utilizing CSS custom properties. Additionally, a byte order mark (BOM) character was added to the Updated class diagram for CSS stylesclassDiagram
class modal-backdrop {
--bs-backdrop-opacity: 0.3
}
class bb-mask {
--bb-mask-opacity: 0.3
}
note for modal-backdrop "Updated to use CSS custom property for backdrop opacity"
note for bb-mask "New class with CSS custom property for mask opacity"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider consolidating the opacity variables into a single place for easier maintenance.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5747 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 657 657
Lines 29923 29923
Branches 4245 4245
=========================================
Hits 29923 29923 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #5746
Summary By Copilot
This pull request includes updates to the styling of mask components in the BootstrapBlazor library. The changes focus on modifying the CSS properties for better control over mask opacity and backdrop appearance.
Styling updates:
src/BootstrapBlazor/Components/Mask/Mask.razor.scss: Corrected the class definition for.bb-maskby adding a byte order mark (BOM) character at the beginning of the file.src/BootstrapBlazor/wwwroot/src/css/motronic.css: Updated the.modal-backdropclass to use a CSS custom property for backdrop opacity and added a new.bb-maskclass with a custom property for mask opacity.Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Update mask and modal backdrop opacity styling using CSS custom properties
Bug Fixes:
Enhancements: