-
-
Notifications
You must be signed in to change notification settings - Fork 364
feat(DevUI): update btn-xs style #5751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request introduces a new button size class No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding the new
--bs-btn-padding-yand--bs-btn-padding-xvariables to the existing button style definitions to avoid creating a new class.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5751 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 657 657
Lines 29923 29923
Branches 4245 4245
=========================================
Hits 29923 29923 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #5750
Summary By Copilot
This pull request includes a small change to the
src/BootstrapBlazor.Server/wwwroot/css/devui.cssfile. The change introduces a new button size class.btn-xswith specific padding values.Changes to button styles:
src/BootstrapBlazor.Server/wwwroot/css/devui.css: Added a new.btn-xsclass with--bs-btn-padding-y: 0and--bs-btn-padding-x: 0.45rem.Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add extra small (xs) button size style to DevUI CSS
New Features:
.btn-xsCSS class with specific padding for extra small buttonsEnhancements: