feat(UniverSheet): support Lang parameter #5755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's Guide by SourceryThis pull request updates the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a brief explanation of why
Datawas replaced withWorkbookData. - It looks like you removed
MessageNameandCommandName- were these unused?
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5755 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 657 657
Lines 29926 29926
Branches 4248 4248
=========================================
Hits 29926 29926 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #5754
Summary By Copilot
This pull request includes updates to dependencies and changes to data handling in the
BootstrapBlazor.Serverproject. The most important changes are the update of theBootstrapBlazor.UniverSheetpackage and the replacement of theDataproperty withWorkbookDatain several instances.Dependency updates:
src/BootstrapBlazor.Server/BootstrapBlazor.Server.csproj: UpdatedBootstrapBlazor.UniverSheetpackage from version9.0.0-beta09to9.0.3.Data handling improvements:
src/BootstrapBlazor.Server/Components/Samples/Tutorials/OnlineSheet/OnlineSheet.razor.cs: ReplacedDatawithWorkbookDatain theUniverSheetDatainitialization inOnInitialized.src/BootstrapBlazor.Server/Components/Samples/UniverSheets.razor.cs: ReplacedDatawithWorkbookDatain theUniverSheetDatainitialization inOnPushExcelData.src/BootstrapBlazor.Server/Components/Samples/UniverSheets.razor.cs: Removed unnecessary propertiesMessageNameandCommandNameinOnPushPluginData.Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Update UniverSheet package and modify data handling to support new Lang parameter
New Features:
Bug Fixes:
Enhancements:
Build: