feat(Tab): compatible with devui style #5757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's Guide by SourceryThis pull request enhances the tab component's styling and functionality by introducing CSS variables, modifying tab item styles, simplifying class assignments, and adding a wrapper for drag-and-drop support. The changes ensure consistent styling across different tab variants and improve the overall appearance and interaction of the component. Updated class diagram for the Tab componentclassDiagram
class Tab {
RenderFragment ChildContent
bool IsBorderCard
}
class TabItem {
RenderFragment HeaderTemplate
bool IsDisabled
bool IsActive
}
Tab *-- TabItem : Contains
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
We encountered an error and are unable to review this PR. We have been notified and are working to fix it.
You can try again by commenting this pull request with @sourcery-ai review, or contact us for help.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5757 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 657 657
Lines 29926 29926
Branches 4248 4248
=========================================
Hits 29926 29926 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #5756
Summary By Copilot
This pull request includes multiple changes to the
BootstrapBlazorproject, focusing on improving the tab component's styling and functionality. The most significant changes involve updating CSS styles, modifying the tab component's Razor and C# files, and ensuring consistent styling across different tab variants.Styling Improvements:
src/BootstrapBlazor.Server/wwwroot/css/devui.css: Added margin tohrelements and updated padding forpre code.hljselements. [1] [2]src/BootstrapBlazor/Components/Tab/Tab.razor.scss: Introduced new CSS variables for tab item padding, close button height, and other styling properties. Updated various selectors to use these variables for consistent styling. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17]Functional Changes:
src/BootstrapBlazor.Server/Components/Samples/Tabs.razor: Simplified the tab item class assignment by removing theGetClassStringmethod and hardcoding the class name.src/BootstrapBlazor.Server/Components/Samples/Tabs.razor.cs: Removed theGetClassStringmethod, as it is no longer needed.Razor Component Updates:
src/BootstrapBlazor/Components/Tab/Tab.razor: Added adivwrapper with a key and class for each tab item header template to support drag-and-drop functionality.Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Enhance the Tab component to be compatible with DevUI styling, introducing more flexible and customizable tab styling with improved CSS variables and structure
New Features:
Enhancements: