feat(Tab): add TabHeader parameter #5787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's Guide by SourceryThis pull request introduces changes to the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a null check for
TabHeaderbefore calling methods on it to avoid potential NullReferenceExceptions. - The removal of
Layout.RegisterTab(this)and the introduction ofSetTabHeadermight introduce a breaking change; ensure existing usages are updated accordingly.
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| if (ShowExtendButtons) | ||
| { | ||
| IsBorderCard = true; | ||
| } |
Contributor
There was a problem hiding this comment.
suggestion: Replacing index-based loops with foreach loops improves clarity.
The refactor to use a foreach loop and fixed builder sequence numbers makes the markup construction more readable. Just ensure that the static sequence numbers do not lead to conflicts when the list is updated dynamically.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5787 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 658 658
Lines 30056 30056
Branches 4243 4243
=========================================
Hits 30056 30056 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #5786
Summary By Copilot
This pull request introduces several changes to the
LayoutandTabcomponents in theBootstrapBlazorlibrary to improve their functionality and integration. The most significant changes include adding a new interface method, modifying component properties, and updating JavaScript initialization logic.Layout and Tab Component Integration:
GetIdmethod toITabHeaderinterface to provide unique identifiers for tab headers. (src/BootstrapBlazor/Components/Tab/ITabHeader.cs)Layoutcomponent to implementITabHeaderand updated theRenderTabHeadermethod to captureLayoutHeaderreferences. (src/BootstrapBlazor/Components/Layout/Layout.razor.cs) [1] [2] [3]Tabcomponent to useITabHeaderinstead ofLayoutfor tab header management and added support fordata-bb-header-idattribute. (src/BootstrapBlazor/Components/Tab/Tab.razor,src/BootstrapBlazor/Components/Tab/Tab.razor.cs) [1] [2] [3] [4] [5] [6] [7] [8] [9]JavaScript Initialization:
initfunction inTab.razor.jsto usedata-bb-header-idfor identifying tab headers, removing dependency onlayoutId. (src/BootstrapBlazor/Components/Tab/Tab.razor.js) [1] [2]Layout Component Improvements:
idattribute totabs-chromediv inLayout.razorfor better DOM manipulation. (src/BootstrapBlazor/Components/Layout/Layout.razor)Layoutproperty withTabHeaderproperty inTabcomponent to decouple tab header logic from layout. (src/BootstrapBlazor/Components/Layout/Layout.razor)These changes enhance the modularity and maintainability of the
LayoutandTabcomponents, making them more flexible and easier to integrate.Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Refactor Tab and Layout components to improve modularity and decouple tab header management by introducing a new ITabHeader interface and updating component interactions
New Features:
Enhancements: