-
-
Notifications
You must be signed in to change notification settings - Fork 363
feat(Slider): update style compatible with row #5797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request updates the Slider component's CSS to be compatible with row layouts by modifying the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- The CSS change looks good, but can you add a comment explaining why the selector was changed?
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5797 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 658 658
Lines 30062 30062
Branches 4244 4244
=========================================
Hits 30062 30062 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #5796
Summary By Copilot
This pull request includes a version update and a modification to the CSS styling in the
Slidercomponent.Version update:
src/BootstrapBlazor/BootstrapBlazor.csproj: Updated the project version from9.5.3to9.5.4.CSS styling modification:
src/BootstrapBlazor/Components/Slider/Slider.razor.scss: Changed the.form-rangeselector to apply styles only to direct children ofdivelements with class names starting with "col-".Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Update Slider component styling to be more compatible with row layouts by refining CSS selector specificity
New Features:
Enhancements: