feat(DateTimeRange): add ShowSelectedValue parameter #5800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's Guide by SourceryThis pull request introduces the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.
Files not reviewed (2)
- src/BootstrapBlazor.Server/Locales/en-US.json: Language not supported
- src/BootstrapBlazor.Server/Locales/zh-CN.json: Language not supported
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a sample that demonstrates the
OnDateClickevent. - The new feature switches could be grouped into a single component for better organization.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5800 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 658 658
Lines 30062 30072 +10
Branches 4244 4246 +2
=========================================
+ Hits 30062 30072 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #5799
Summary By Copilot
This pull request includes several updates to the
DateTimeRangecomponent and its associated sample and localization files. The changes introduce new features, enhance existing functionality, and improve code consistency.New Features and Enhancements:
DateTimeRangecomponent. (src/BootstrapBlazor.Server/Components/Samples/DateTimeRanges.razor)ShowSelectedValueto display the selected date range in the component. (src/BootstrapBlazor.Server/Components/Samples/DateTimeRanges.razor,src/BootstrapBlazor/Components/DateTimeRange/DateTimeRange.razor.cs) [1] [2]OnDateClickto handle date cell click events. (src/BootstrapBlazor/Components/DateTimeRange/DateTimeRange.razor.cs)Code Improvements:
UpdateValuemethod and removed unused imports. (src/BootstrapBlazor/Components/DateTimeRange/DateTimeRange.razor.cs) [1] [2] [3]ShowSelectedValueandOnDateClick. (test/UnitTest/Components/DateTimeRangeTest.cs)Localization Updates:
src/BootstrapBlazor.Server/Locales/en-US.json,src/BootstrapBlazor.Server/Locales/zh-CN.json) [1] [2]Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Enhance the DateTimeRange component by adding new features for displaying selected values and improving date selection interactions
New Features:
Enhancements:
Documentation:
Tests: