-
-
Notifications
You must be signed in to change notification settings - Fork 363
feat(DateTimeRange): add AutoClose parameter #5802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request introduces the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 6 changed files in this pull request and generated no comments.
Files not reviewed (3)
- src/BootstrapBlazor.Server/Locales/en-US.json: Language not supported
- src/BootstrapBlazor.Server/Locales/zh-CN.json: Language not supported
- src/BootstrapBlazor/BootstrapBlazor.csproj: Language not supported
Comments suppressed due to low confidence (2)
test/UnitTest/Components/DateTimeRangeTest.cs:123
- [nitpick] Consider translating the comment to English to maintain consistency across the codebase.
// 由于设置了 AutoClose 属性所以这里不需要点击确定按钮
src/BootstrapBlazor/Components/DateTimeRange/DateTimeRange.razor.cs:105
- [nitpick] Consider rephrasing the summary to 'Gets or sets whether to automatically close the popup after a date range is selected.' for clarity.
/// Gets or sets whether to auto close the popup when the user selected range value. Default is false.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a unit test to verify that the popup does not close when
AutoCloseis false and a date range is selected.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5802 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 658 658
Lines 30072 30079 +7
Branches 4246 4247 +1
=========================================
+ Hits 30072 30079 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 6 changed files in this pull request and generated no comments.
Files not reviewed (3)
- src/BootstrapBlazor.Server/Locales/en-US.json: Language not supported
- src/BootstrapBlazor.Server/Locales/zh-CN.json: Language not supported
- src/BootstrapBlazor/BootstrapBlazor.csproj: Language not supported
|
@sourcery-ai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a
Closemethod to the component to allow programmatic closing of the popup, in addition to theAutoCloseparameter.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Link issues
fixes #5801
Summary By Copilot
This pull request introduces new functionality to the
DateTimeRangecomponent, including the ability to automatically close the popup when a date range is selected. It also updates the documentation and tests to reflect these changes.Enhancements to
DateTimeRangecomponent:src/BootstrapBlazor.Server/Components/Samples/DateTimeRanges.razor: Added theAutoCloseattribute to enable automatic closing of the popup when a date range is selected.src/BootstrapBlazor/Components/DateTimeRange/DateTimeRange.razor.cs: Introduced theAutoCloseparameter and updated theUpdateValuemethod to close the popup automatically if theAutoCloseattribute is set to true and both start and end dates are selected. [1] [2]Documentation updates:
src/BootstrapBlazor.Server/Locales/en-US.json: Updated theBindValueIntroto include information about the newAutoCloseattribute.src/BootstrapBlazor.Server/Locales/zh-CN.json: Updated theBindValueIntroto include information about the newAutoCloseattribute.Version update:
src/BootstrapBlazor/BootstrapBlazor.csproj: Incremented the version number from 9.5.4 to 9.5.5.Test updates:
test/UnitTest/Components/DateTimeRangeTest.cs: Added tests to verify the functionality of theAutoCloseattribute, ensuring the popup closes automatically upon date selection. [1] [2]Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add AutoClose parameter to DateTimeRange component to automatically close the popup when a date range is selected
New Features:
Enhancements:
Documentation:
Tests: