feat(ShieldBadge): add ShieldBadge component #5804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's Guide by SourceryThis pull request introduces the new No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Copilot reviewed 7 out of 13 changed files in this pull request and generated no comments.
Files not reviewed (6)
- src/BootstrapBlazor.Server/Components/Components/DemoBlock.razor.css: Language not supported
- src/BootstrapBlazor.Server/Locales/en-US.json: Language not supported
- src/BootstrapBlazor.Server/Locales/zh-CN.json: Language not supported
- src/BootstrapBlazor.Server/docs.json: Language not supported
- src/BootstrapBlazor/Components/Badge/ShieldBadge.razor.scss: Language not supported
- src/BootstrapBlazor/wwwroot/scss/components.scss: Language not supported
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a default Icon value to the ShieldBadge component to improve its usability out-of-the-box.
- The ShieldBadge component's SCSS file should include comments to explain the purpose of each style.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟡 Testing: 2 issues found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5804 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 658 660 +2
Lines 30079 30111 +32
Branches 4247 4250 +3
=========================================
+ Hits 30079 30111 +32 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #5803
Summary By Copilot
This pull request introduces the new
ShieldBadgecomponent, updates related documentation and localization files, and includes new unit tests. The most important changes are summarized below.New Component Addition:
src/BootstrapBlazor/Components/Badge/ShieldBadge.razor: Added the newShieldBadgecomponent.src/BootstrapBlazor/Components/Badge/ShieldBadge.razor.cs: Implemented theShieldBadgecomponent with various parameters such asIcon,Label,Text,Radius, and their respective color properties.src/BootstrapBlazor/Components/Badge/ShieldBadge.razor.scss: Added styling for theShieldBadgecomponent.Documentation and Localization Updates:
src/BootstrapBlazor.Server/Components/Samples/ShieldBadges.razor: Added a sample page for theShieldBadgecomponent.src/BootstrapBlazor.Server/Components/Samples/ShieldBadges.razor.cs: Added the code-behind for theShieldBadgessample page.src/BootstrapBlazor.Server/Locales/en-US.json: Added English localization entries for theShieldBadgecomponent. [1] [2]src/BootstrapBlazor.Server/Locales/zh-CN.json: Added Chinese localization entries for theShieldBadgecomponent. [1] [2]src/BootstrapBlazor.Server/docs.json: Updated documentation index to include theShieldBadgecomponent.Unit Tests:
test/UnitTest/Components/ShieldBadgeTest.cs: Added unit tests for theShieldBadgecomponent to verify its functionality and parameter handling.Minor Changes:
src/BootstrapBlazor.Server/Components/Components/DemoBlock.razor.css: Adjusted the width of the.pre-codeclass in the.card-footer-codesection.src/BootstrapBlazor/Components/Badge/Badge.razor.cs: Updated theBadgecomponent to improve code readability and documentation comments.src/BootstrapBlazor/wwwroot/scss/components.scss: Included theShieldBadgeSCSS file in the main components SCSS file. [1] [2]src/BootstrapBlazor.Server/Extensions/MenusLocalizerExtensions.cs: Added a menu item for theShieldBadgesample page.Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add a new ShieldBadge component to the BootstrapBlazor library, providing a flexible and customizable badge with icon, label, and text sections
New Features:
Enhancements:
Documentation:
Tests:
Chores: