-
-
Notifications
You must be signed in to change notification settings - Fork 363
fix(AutoComplete): tabbing off AutoComplete field does not close its drop down #5816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request updates the project version and modifies the event handling logic in the Sequence diagram for handling Tab key in AutoCompletesequenceDiagram
participant User
participant AutoCompleteInput as Input
participant AutoCompleteObject as ACO
User->>Input: Presses Tab key
Input->>ACO: handlerKeydown(event)
ACO->>ACO: triggerBlur()
ACO->>Input: blur()
Input-->>User: Dropdown closes
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Moving the event handler from
keyuptokeydownseems risky; can you explain why this is safe? - Consider adding a comment explaining why the Tab key needs special handling.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5816 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 660 660
Lines 30125 30125
Branches 4251 4251
=========================================
Hits 30125 30125 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #5815
Summary By Copilot
This pull request includes several changes to the
BootstrapBlazorproject, focusing on updating the project version and modifying the event handling logic in theAutoCompletecomponent.Version Update:
src/BootstrapBlazor/BootstrapBlazor.csproj: Updated the project version from9.5.6-beta01to9.5.6-beta02.Event Handling Modifications:
src/BootstrapBlazor/Components/AutoComplete/AutoComplete.razor.js: Changed event handling fromkeyuptokeydownfor better performance and added handling for theTabkey to trigger blur. [1] [2] [3] [4]Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Improve AutoComplete component's keyboard interaction by fixing tab key behavior and updating event handling
Bug Fixes:
Enhancements: