-
-
Notifications
You must be signed in to change notification settings - Fork 363
fix(AutoComplete): tabbing off AutoComplete field does not close its drop down #5818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request updates the project version and modifies the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- It looks like the handlerKeydown function was modified to accept the AutoComplete instance, but the handlerKeyup function was not.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5818 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 660 660
Lines 30125 30125
Branches 4251 4251
=========================================
Hits 30125 30125 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #5815
Summary By Copilot
This pull request includes updates to the version number in the project file and modifications to the
AutoCompletecomponent's JavaScript file to improve event handling.Version update:
src/BootstrapBlazor/BootstrapBlazor.csproj: Updated the project version from9.5.6-beta03to9.5.6-beta04.Event handling improvements in
AutoCompletecomponent:src/BootstrapBlazor/Components/AutoComplete/AutoComplete.razor.js: Modified thehandlerKeydownfunction to acceptac(AutoComplete instance) as a parameter and updated the event handler calls to passacalong with the event object. [1] [2]Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Fix event handling in AutoComplete component to properly close dropdown when tabbing off the field
Bug Fixes:
Enhancements: