-
-
Notifications
You must be signed in to change notification settings - Fork 363
refactor(AutoComplete): auto close dropdown box after press tab #5833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request refactors the AutoComplete component to improve its behavior when the tab key is pressed. It introduces a blur event handler to close the auto-complete suggestions on tab key press and updates the keyup event handler to use a method for showing suggestions. Sequence diagram for closing AutoComplete on Tab key presssequenceDiagram
participant User
participant AutoCompleteInput as Input
participant AutoCompleteDropdown as Dropdown
User->>Input: Presses Tab key
Input-->>Document: blur event
Document->>AutoComplete: ac.blur(event)
AutoComplete->>Dropdown: close()
Dropdown-->>AutoComplete: Hides suggestions
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a check in the blur handler to ensure the tab key press actually originated from within the auto-complete component.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5833 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 660 660
Lines 30114 30114
Branches 4252 4252
=========================================
Hits 30114 30114 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #5832
Summary By Copilot
This pull request includes changes to the
AutoCompletecomponent in thesrc/BootstrapBlazor/Components/AutoComplete/AutoComplete.razor.jsfile to improve its behavior and functionality. The most important changes include adding a new blur event handler to close the auto-complete suggestions on tab key press, and updating the keyup event handler to use a method for showing suggestions.Improvements to AutoComplete behavior:
blurevent handler to close the auto-complete suggestions when the tab key is pressed.ac.show()method instead of directly adding the 'show' class.disposefunction to remove thekeyupevent listener for theblurhandler.Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Improve AutoComplete component's dropdown behavior by adding tab key handling and refactoring event management
Bug Fixes:
Enhancements: