Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Apr 16, 2025

Link issues

fixes #5829

Summary By Copilot

This pull request includes several changes to the BootstrapBlazor project, focusing on version updates and improvements to the Select component's state management. The most important changes include updating the project version and ensuring the _lastSelectedValueString is reset appropriately.

Version Update:

State Management Improvements in Select Component:

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Fix state management issue in Select component to allow reselecting a value after clearing

Bug Fixes:

  • Resolve an issue where the Select component could not select a value again after being cleared programmatically by resetting the internal state

Enhancements:

  • Improve Select component's state management by explicitly resetting internal tracking variables

@bb-auto bb-auto bot added the bug Something isn't working label Apr 16, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Apr 16, 2025

Reviewer's Guide by Sourcery

This pull request updates the project version and improves the Select component's state management by ensuring _lastSelectedValueString is reset appropriately when the value is null or cleared.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
The project version was updated.
  • Updated the project version from 9.5.7-beta01 to 9.5.7.
src/BootstrapBlazor/BootstrapBlazor.csproj
The component's state management was improved to ensure the _lastSelectedValueString is reset appropriately.
  • Initialized _lastSelectedValueString to an empty string when Value is null in the SelectedItem? SelectedRow method.
  • Reset _lastSelectedValueString to an empty string in the OnClearValue method.
src/BootstrapBlazor/Components/Select/Select.razor.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#5829 After clearing the selected value in the Select component via code (by setting the bound value to null), the user should be able to re-select the same value again.
#5829 Provide a better way to clear the selected value via code, or correctly handle the existing method of assigning null to the bound value.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added this to the v9.5.0 milestone Apr 16, 2025
@ArgoZhang ArgoZhang merged commit a22b394 into main Apr 16, 2025
3 checks passed
@ArgoZhang ArgoZhang deleted the fix-select branch April 16, 2025 11:29
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The changes look good, but it would be helpful to have a test case to ensure the bug is fixed and doesn't regress in the future.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (dbb9b8d) to head (4efbb0f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #5834   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          660       660           
  Lines        30114     30116    +2     
  Branches      4252      4252           
=========================================
+ Hits         30114     30116    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(Select): cannot select value again after clear by code

2 participants