-
-
Notifications
You must be signed in to change notification settings - Fork 363
fix(Select): cannot select value again after clear by code #5834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request updates the project version and improves the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- The changes look good, but it would be helpful to have a test case to ensure the bug is fixed and doesn't regress in the future.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5834 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 660 660
Lines 30114 30116 +2
Branches 4252 4252
=========================================
+ Hits 30114 30116 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #5829
Summary By Copilot
This pull request includes several changes to the
BootstrapBlazorproject, focusing on version updates and improvements to theSelectcomponent's state management. The most important changes include updating the project version and ensuring the_lastSelectedValueStringis reset appropriately.Version Update:
src/BootstrapBlazor/BootstrapBlazor.csproj: Updated the project version from9.5.7-beta01to9.5.7.State Management Improvements in
SelectComponent:src/BootstrapBlazor/Components/Select/Select.razor.cs: Added initialization of_lastSelectedValueStringto an empty string whenValueis null in theprivate SelectedItem? SelectedRowmethod.src/BootstrapBlazor/Components/Select/Select.razor.cs: Reset_lastSelectedValueStringto an empty string in theprotected override async Task OnClearValue()method.Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Fix state management issue in Select component to allow reselecting a value after clearing
Bug Fixes:
Enhancements: