Skip to content

Conversation

@MadLongTom
Copy link
Collaborator

@MadLongTom MadLongTom commented Apr 17, 2025

Link issues

discussion #5828
close #5852

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Chores:

  • Added JsonDerivedType attribute to enable polymorphic JSON serialization for IFilterAction interface

@bb-auto
Copy link

bb-auto bot commented Apr 17, 2025

Thanks for your PR, @MadLongTom. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Apr 17, 2025

Reviewer's Guide by Sourcery

The pull request adds support for serialization in the IFilterAction interface by introducing a JsonDerivedType attribute.

Updated class diagram for IFilterAction interface

classDiagram
    class IFilterAction {
        <<interface>>
    }
    class SearchFilterAction
    IFilterAction <|-- SearchFilterAction : implements
    note for IFilterAction "Added JsonDerivedType attribute for serialization support"
Loading

File-Level Changes

Change Details Files
Added support for serialization in the IFilterAction interface.
  • Imported System.Text.Json.Serialization namespace.
  • Added JsonDerivedType attribute to the IFilterAction interface.
src/BootstrapBlazor/Components/Filters/IFilterAction.cs

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot requested a review from ArgoZhang April 17, 2025 03:38
sourcery-ai[bot]
sourcery-ai bot previously approved these changes Apr 17, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @MadLongTom - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Apr 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ad698e2) to head (13a155d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main     #5840    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          660       661     +1     
  Lines        30139     30403   +264     
  Branches      4257      4319    +62     
==========================================
+ Hits         30139     30403   +264     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ArgoZhang ArgoZhang changed the title chore(IFilterAction): support serialization chore(QueryPageOptions): support serialization Apr 22, 2025
@ArgoZhang ArgoZhang changed the title chore(QueryPageOptions): support serialization feat(QueryPageOptions): support serialization Apr 22, 2025
@ArgoZhang ArgoZhang merged commit 53c934a into main Apr 22, 2025
4 checks passed
@ArgoZhang ArgoZhang deleted the chore(QueryPageOptions) branch April 22, 2025 07:03
@bb-auto bb-auto bot added the enhancement New feature or request label Apr 22, 2025
@bb-auto bb-auto bot added this to the v9.5.0 milestone Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(QueryPageOption): Support IFilterAction serialization

3 participants