-
-
Notifications
You must be signed in to change notification settings - Fork 363
feat(QueryPageOptions): support serialization #5840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your PR, @MadLongTom. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Reviewer's Guide by SourceryThe pull request adds support for serialization in the IFilterAction interface by introducing a JsonDerivedType attribute. Updated class diagram for IFilterAction interfaceclassDiagram
class IFilterAction {
<<interface>>
}
class SearchFilterAction
IFilterAction <|-- SearchFilterAction : implements
note for IFilterAction "Added JsonDerivedType attribute for serialization support"
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @MadLongTom - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5840 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 660 661 +1
Lines 30139 30403 +264
Branches 4257 4319 +62
==========================================
+ Hits 30139 30403 +264 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
discussion #5828
close #5852
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Chores: