-
-
Notifications
You must be signed in to change notification settings - Fork 363
feat(DefaultTableExport): add EnableAutoFilter/EnableAutoWidth property #5846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your PR, @densen2014. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Reviewer's Guide by SourceryThis pull request introduces two new boolean options to the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @densen2014 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider if
EnableAutoWidthshould default totruefor a better user experience.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5846 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 660 660
Lines 30136 30138 +2
Branches 4257 4257
=========================================
+ Hits 30136 30138 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ty (#5846) * feat(DefaultTableExport): 添加是否启用 Excel 自动筛选,是否启用 Excel 自动宽度参数 #5845 * doc: 更新注释为英文 * chore: bump version 9.5.8 * refactor: 更改参数名称 * test: 更新单元测试 --------- Co-authored-by: Argo Zhang <[email protected]>
Link issues
fixes #5845
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
New Features: