Skip to content

Conversation

@syminomega
Copy link
Collaborator

@syminomega syminomega commented Apr 22, 2025

Issues

close #5860

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Add smooth scrolling to bottom functionality for Scroll component in Blazor

New Features:

  • Implement a ScrollToBottom method for the Scroll component that smoothly animates scrolling to the bottom of a scrollable container

Enhancements:

  • Upgrade Scroll component to use BootstrapModuleComponentBase for improved module handling
  • Add JavaScript implementation for smooth scrolling animation

Tests:

  • Update demo page to showcase new ScrollToBottom functionality with a button trigger

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Apr 22, 2025

Reviewer's Guide by Sourcery

This pull request introduces a smooth scrolling to bottom feature for the Scroll component. It includes changes to the Scroll component's C# code, Razor markup, and the addition of a JavaScript file to handle the animation. A demo has also been added to showcase the new functionality.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added a smooth scrolling to bottom feature to the Scroll component.
  • Added a ScrollToBottom method to the Scroll component to trigger smooth scrolling.
  • Implemented javascript function scrollToBottom to handle the smooth scrolling animation.
  • Added a button to the sample page to demonstrate the ScrollToBottom functionality.
src/BootstrapBlazor/Components/Scroll/Scroll.razor.cs
src/BootstrapBlazor/Components/Scroll/Scroll.razor
src/BootstrapBlazor/Components/Scroll/Scroll.razor.js
src/BootstrapBlazor.Server/Components/Samples/Scrolls.razor
src/BootstrapBlazor.Server/Components/Samples/Scrolls.razor.cs

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto
Copy link

bb-auto bot commented Apr 22, 2025

Thanks for your PR, @syminomega. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@bb-auto bb-auto bot requested a review from ArgoZhang April 22, 2025 08:32
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We encountered an error and are unable to review this PR. We have been notified and are working to fix it.

You can try again by commenting this pull request with @sourcery-ai review, or contact us for help.

ArgoZhang
ArgoZhang previously approved these changes Apr 22, 2025
@ArgoZhang ArgoZhang changed the title feat(Scroll): 添加平滑滚动到底部的功能,用于聊天框和动态条目展示等 feat(Scroll): add ScrollToBottom method Apr 22, 2025
@bb-auto bb-auto bot added the enhancement New feature or request label Apr 22, 2025
@bb-auto bb-auto bot added this to the v9.5.0 milestone Apr 22, 2025
@ArgoZhang
Copy link
Member

@syminomega 请签署 CLA 按照上面的提示即可

ArgoZhang
ArgoZhang previously approved these changes Apr 22, 2025
@codecov
Copy link

codecov bot commented Apr 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (53c934a) to head (5fcaaec).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #5858   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          661       661           
  Lines        30403     30404    +1     
  Branches      4319      4319           
=========================================
+ Hits         30403     30404    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ArgoZhang ArgoZhang merged commit 358e500 into dotnetcore:main Apr 23, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(Scroll): add ScrollToBottom method

2 participants