feat(Dialog): add IsHidePreviousDialog parameter #5866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's Guide by SourceryThis pull request introduces a new No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a demo page to showcase the new
IsHidePreviousDialogfeature. - The CSS changes introduce a new class
.modal-multiple; ensure this doesn't conflict with existing styles.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5866 +/- ##
===========================================
- Coverage 100.00% 99.99% -0.01%
===========================================
Files 661 661
Lines 30404 30411 +7
Branches 4319 4319
===========================================
+ Hits 30404 30410 +6
- Partials 0 1 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #5865
Summary By Copilot
This pull request introduces enhancements to the
DialogandModalDialogcomponents in the BootstrapBlazor library, focusing on support for managing multiple dialogs and improving customization options. Key changes include adding a newIsHidePreviousDialogproperty, updating the CSS for handling overlapping dialogs, and refining the behavior of dialog rendering.Enhancements to dialog management:
New
IsHidePreviousDialogproperty: Added a property toDialogOptionandModalDialogto control whether the previous dialog should be hidden when a new one is opened. This property defaults tofalseand is passed as an attribute inToAttributes(). (src/BootstrapBlazor/Components/Dialog/DialogOption.cs: [1] [2];src/BootstrapBlazor/Components/Modal/ModalDialog.razor.cs: [3]CSS updates for overlapping dialogs: Introduced the
.modal-multipleclass to handle multiple dialogs more effectively. This includes styling for fixed positioning, background opacity, and hiding modal backdrops for all but the last dialog. (src/BootstrapBlazor/Components/Modal/Modal.razor.scss: src/BootstrapBlazor/Components/Modal/Modal.razor.scssR73-R90)Improvements to dialog rendering:
Dynamic class generation: Added a
ClassStringproperty to theDialogcomponent to dynamically apply CSS classes based on the number of active dialogs. (src/BootstrapBlazor/Components/Dialog/Dialog.razor.cs: src/BootstrapBlazor/Components/Dialog/Dialog.razor.csR32-R36)Class binding in
Dialog.razor: Updated theDialogcomponent to bind theClassStringproperty to theclassattribute of the modal, enabling the new styling for multiple dialogs. (src/BootstrapBlazor/Components/Dialog/Dialog.razor: src/BootstrapBlazor/Components/Dialog/Dialog.razorL5-R5)Versioning:
9.5.11-beta01to reflect the new features and enhancements. (src/BootstrapBlazor/BootstrapBlazor.csproj: src/BootstrapBlazor/BootstrapBlazor.csprojL4-R4)Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add support for managing multiple dialogs with a new IsHidePreviousDialog parameter and improved styling for overlapping dialogs
New Features:
Enhancements: