fix(Button): IsAsync parameter support wpf

[ArgoZhang]

Link issues

fixes #5863

Summary By Copilot

Regression?

• Yes
• No

Risk

• High
• Medium
• Low

Verification

• Manual (required)
• Automated

Packaging changes reviewed?

• Yes
• No
• N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

• Doc is updated/provided or not needed
• Demo is updated/provided or not needed
• Merge the latest code from the main branch

Summary by Sourcery

Modify button component handling of async operations to simplify and improve async click event processing

Bug Fixes:

• Refactor async button click handling to remove unnecessary Task.Run() and simplify event processing

Enhancements:

• Streamline async button click mechanism across different button components
• Improve consistency in handling async click events

[sourcery-ai]

Reviewer's Guide by Sourcery

The pull request refactors the button click handlers in Button.razor.cs, PopConfirmButton.razor.cs, and CountButton.cs to simplify asynchronous operations by removing unnecessary Task.Run and InvokeAsync calls. This streamlines the code and potentially improves performance.

Sequence Diagram for Button Click Handling in Button.razor.cs

sequenceDiagram
    participant User
    participant Button
    participant Handler

    User->>Button: Click
    activate Button
    Button->>Handler: HandlerClick()
    activate Handler
    Handler-->>Button: Return
    deactivate Handler
    Button->>Button: Restore Button State (if IsAsync and ButtonType == ButtonType.Button)
    Button-->>User: Update UI
    deactivate Button

Loading

Sequence Diagram for Confirm Button Click Handling in PopConfirmButton.razor.cs

sequenceDiagram
    participant User
    participant PopConfirmButton
    participant OnConfirmHandler

    User->>PopConfirmButton: Click Confirm
    activate PopConfirmButton
    PopConfirmButton->>PopConfirmButton: Disable Button, Set IsAsyncLoading
    PopConfirmButton->>OnConfirmHandler: OnConfirm()
    activate OnConfirmHandler
    OnConfirmHandler-->>PopConfirmButton: Return
    deactivate OnConfirmHandler
    PopConfirmButton->>PopConfirmButton: Handle ButtonType (Submit)
    PopConfirmButton-->>User: Update UI
    deactivate PopConfirmButton

Loading

Sequence Diagram for Button Click Handling in CountButton.cs

sequenceDiagram
    participant User
    participant CountButton
    participant Handler

    User->>CountButton: Click
    activate CountButton
    CountButton->>CountButton: Set IsAsyncLoading, IsDisabled
    CountButton->>Handler: HandlerClick()
    activate Handler
    Handler-->>CountButton: Return
    deactivate Handler
    CountButton->>CountButton: UpdateCount()
    CountButton->>CountButton: Reset IsDisabled, IsAsyncLoading
    CountButton-->>User: Update UI
    deactivate CountButton

Loading

File-Level Changes

Change	Details	Files
Refactored button click handlers to remove Task.Run and InvokeAsync calls, simplifying the asynchronous execution flow.	Removed Task.Run and InvokeAsync from OnClickButton in Button.razor.cs. Removed Task.Run and InvokeAsync from OnClickConfirm in PopConfirmButton.razor.cs. Removed Task.Run and InvokeAsync from OnClickButton in CountButton.cs.	src/BootstrapBlazor/Components/Button/Button.razor.cs src/BootstrapBlazor/Components/Button/PopConfirmButton.razor.cs src/BootstrapBlazor/Components/Button/CountButton.cs

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#5878	Correct the async button click handling to ensure proper execution of click handlers in WPF Blazor mode.	✅
#5878	Simplify the async button click mechanism by removing unnecessary Task.Run wrapping.	✅

Possibly linked issues

• fix(Button): IsAsync parameter support wpf #5878: The PR removes Task.Run from button click handlers, directly impacting the IsAsync behavior reported in the issue.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

• It looks like you're removing the IsAsync check and Task.Run calls, but still setting IsDisabled and IsAsyncLoading based on IsAsync - can you confirm this is the intended behavior?

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9f0d084) to head (37e719b).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main     #5890   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          661       661           
  Lines        30430     30421    -9     
  Branches      4323      4321    -2     
=========================================
- Hits         30430     30421    -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.