chore(Button): remove Task.Run in event callback

[ArgoZhang]

Link issues

fixes #5863

Summary By Copilot

Regression?

• Yes
• No

Risk

• High
• Medium
• Low

Verification

• Manual (required)
• Automated

Packaging changes reviewed?

• Yes
• No
• N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

• Doc is updated/provided or not needed
• Demo is updated/provided or not needed
• Merge the latest code from the main branch

Summary by Sourcery

Remove unnecessary Task.Run usage in button component event callbacks

Bug Fixes:

• Eliminate potential unnecessary threading overhead in button click event handlers

Enhancements:

• Streamline asynchronous event handling in Button, PopConfirmButton, and CountButton components

Chores:

• Simplify button component event handling by removing redundant Task.Run calls

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request removes the use of Task.Run in the event callbacks of the Button, PopConfirmButton, and CountButton components. The change simplifies the event handling logic by directly awaiting the asynchronous operations.

Sequence diagram for Button click event

sequenceDiagram
    participant Button
    participant Handler

    Button->>Handler: HandlerClick()
    activate Handler
    Handler-->>Button: Task
    deactivate Handler

Loading

Sequence diagram for PopConfirmButton confirm event

sequenceDiagram
    participant PopConfirmButton
    participant OnConfirm

    PopConfirmButton->>OnConfirm: OnConfirm()
    activate OnConfirm
    OnConfirm-->>PopConfirmButton: Task
    deactivate OnConfirm

Loading

Sequence diagram for CountButton click event

sequenceDiagram
    participant CountButton
    participant Handler

    CountButton->>Handler: HandlerClick()
    activate Handler
    Handler-->>CountButton: Task
    deactivate Handler
    CountButton->>CountButton: UpdateCount()
    activate CountButton
    CountButton-->>CountButton: Task
    deactivate CountButton

Loading

File-Level Changes

Change	Details	Files
Removed Task.Run from event callbacks in Button, PopConfirmButton, and CountButton components.	Removed Task.Run from the OnClickButton method in Button.razor.cs. Removed Task.Run from the OnClickConfirm method in PopConfirmButton.razor.cs. Removed Task.Run from the OnClickButton method in CountButton.cs.	src/BootstrapBlazor/Components/Button/Button.razor.cs src/BootstrapBlazor/Components/Button/PopConfirmButton.razor.cs src/BootstrapBlazor/Components/Button/CountButton.cs

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#5863	The IsAsync property of the Button component should correctly display a loading state and disable the button while an asynchronous operation is in progress in a WPF Blazor application.	✅
#5863	Clicking the button rapidly should not cause the counter to increment uncontrollably while the button is in an asynchronous loading state.	✅

Possibly linked issues

• bug(Button): 再wpf blazor模式下, button 的 IsAsync 不工作 #5863: The PR removes Task.Run, which might fix the IsAsync bug by ensuring the UI updates correctly.
• bug(Button): 再wpf blazor模式下, button 的 IsAsync 不工作 #5863: The PR removes Task.Run from Button, PopConfirmButton, and CountButton, which might fix the issue described.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider adding a comment explaining why Task.Run was removed from the event callbacks.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9f0d084) to head (b2eefd6).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main     #5891   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          661       661           
  Lines        30430     30421    -9     
  Branches      4323      4321    -2     
=========================================
- Hits         30430     30421    -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.