feat(LayoutSpitBar): rename LayoutSplitBar component name #5915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's Guide by SourceryThis pull request renames the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR renames the LayoutSplitebar component to LayoutSplitBar to correct a spelling mistake and ensure naming consistency across the codebase.
- Renames component classes, file names, and related properties.
- Updates test cases, JavaScript log messages, and localization keys to use the corrected naming.
- Marks the deprecated property ShowSplitebar with an Obsolete attribute.
Reviewed Changes
Copilot reviewed 10 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/UnitTest/Components/LayoutTest.cs | Updated test case naming and assertions to reflect the new property/component name. |
| test/UnitTest/Components/LayoutSplitebarTest.cs | Renamed test class and method for consistency. |
| src/BootstrapBlazor/Components/Layout/LayoutSplitBar.razor.js | Updated log messages and query selectors to use the new class names. |
| src/BootstrapBlazor/Components/Layout/LayoutSplitBar.razor.cs | Renamed the component class to LayoutSplitBar. |
| src/BootstrapBlazor/Components/Layout/LayoutSplitBar.razor | Updated Razor markup and module auto-loader attribute. |
| src/BootstrapBlazor/Components/Layout/Layout.razor.cs | Updated properties from ShowSplitebar to ShowSplitBar and marked the obsolete one. |
| src/BootstrapBlazor/Components/Layout/Layout.razor | Updated usage of the deprecated component and property. |
| src/BootstrapBlazor.Server/Components/Samples/Layouts.razor.cs | Revised attribute definitions to use ShowSplitBar. |
| src/BootstrapBlazor.Server/Components/Layout/TutorialsLayout.razor | Updated component usage to the new name. |
| src/BootstrapBlazor.Server/Components/Layout/MainLayout.razor | Updated component usage to the new name. |
Files not reviewed (5)
- src/BootstrapBlazor.Server/Locales/en-US.json: Language not supported
- src/BootstrapBlazor.Server/Locales/zh-CN.json: Language not supported
- src/BootstrapBlazor/Components/Layout/LayoutSplitBar.razor.scss: Language not supported
- src/BootstrapBlazor/wwwroot/scss/components.scss: Language not supported
- src/BootstrapBlazor/wwwroot/scss/theme/bootstrapblazor.scss: Language not supported
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5915 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 665 665
Lines 30485 30485
Branches 4345 4345
=========================================
Hits 30485 30485 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #5914
Summary By Copilot
This pull request focuses on renaming the
LayoutSplitebarcomponent toLayoutSplitBaracross the codebase to correct a spelling error and improve consistency. It includes updates to component names, properties, CSS classes, localization keys, and test cases. Additionally, a deprecated property (ShowSplitebar) has been marked obsolete in favor of the correctedShowSplitBar.Component Renaming and Updates:
LayoutSplitebarcomponent toLayoutSplitBarin all related files, including.razor,.razor.cs,.razor.js, and.razor.scss. Updated associated CSS classes and JavaScript references [1] [2] [3] [4] [5] [6] [7].$bb-split-bar-body-hover-bgand$bb-split-bar-body-drag-hover-bg).components.scssto reference the renamed SCSS file.Property and Localization Key Changes:
ShowSplitebarproperty withShowSplitBarin theLayoutcomponent and markedShowSplitebaras obsolete with a deprecation warning.en-US.jsonandzh-CN.jsonto useShowSplitBarinstead ofShowSplitebar[1] [2].Test Updates:
LayoutSplitBarandShowSplitBar) [1] [2].Codebase-Wide Usage Updates:
LayoutSplitebarwithLayoutSplitBarin Razor files, includingMainLayout.razorandTutorialsLayout.razor[1] [2].Layouts.razor.csto reflect the corrected property name.Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Rename the
LayoutSplitebarcomponent toLayoutSplitBarto correct a typo.Enhancements:
ShowSplitebarproperty in theLayoutcomponent as obsolete and introduce the correctly spelledShowSplitBarproperty.