Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented May 4, 2025

Link issues

fixes #5958

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Update CSS styles for Tab and Layout components to improve fullscreen and responsive behavior

New Features:

  • Add fullscreen-specific styling for Tab component
  • Implement dynamic height and overflow handling for tabs

Bug Fixes:

  • Fix tab body height and overflow issues in different display states

Enhancements:

  • Refactor Tab and Layout component CSS to improve layout flexibility
  • Add CSS variables for better responsive design

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented May 4, 2025

Reviewer's Guide

This pull request introduces CSS changes to support a fullscreen state for the Tab component. It utilizes the :fullscreen pseudo-class in Tab.razor.scss to enable scrolling within the tab body and in Layout.razor.scss to hide the layout's header and footer when a tab is fullscreen. Selectors for .tabs-body were also refined using the direct child combinator (>) for improved specificity.

File-Level Changes

Change Details Files
Implemented fullscreen styling for Tabs and Layout.
  • Added :fullscreen selector to .tabs to set overflow: auto on .tabs-body.
  • Added :fullscreen selector to .layout-main > .tabs to set layout header/footer height variables to 0px.
src/BootstrapBlazor/Components/Tab/Tab.razor.scss
src/BootstrapBlazor/Components/Layout/Layout.razor.scss
Refactored Tab component CSS selectors.
  • Changed .tabs-body selectors to use the direct child combinator (>).
  • Moved .tabs-body styles into the main .tabs block.
  • Added :not(:has(> .tabs-header)) selector to adjust body height when no header exists.
  • Removed older, less specific .tabs .tabs-body and .tabs .tabs-content rules.
src/BootstrapBlazor/Components/Tab/Tab.razor.scss
src/BootstrapBlazor/Components/Layout/Layout.razor.scss

Assessment against linked issues

Issue Objective Addressed Explanation
#5958 Update CSS for the Tab component's fullscreen state.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the enhancement New feature or request label May 4, 2025
@bb-auto bb-auto bot added this to the v9.6.0 milestone May 4, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

  • Consider if the increased specificity from using the direct child combinator (>) in selectors like > .tabs-body is necessary or if less specific selectors would suffice.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang ArgoZhang merged commit a48cdef into main May 4, 2025
4 checks passed
@ArgoZhang ArgoZhang deleted the feat-tab branch May 4, 2025 06:48
@codecov
Copy link

codecov bot commented May 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2f518f9) to head (8e721e7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #5959   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          670       670           
  Lines        30576     30576           
  Branches      4350      4350           
=========================================
  Hits         30576     30576           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(Tab): update css for fullscreen state

2 participants