-
-
Notifications
You must be signed in to change notification settings - Fork 364
fix(ErrorLogger): add custom OnErrorHandleAsync on Layout not work #6004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis pull request updates the File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
- Invoking
OnErrorHandleAsyncnow prevents the default ErrorBoundary UI from rendering the error; clarify if custom handlers are expected to manage all UI aspects. - Consider passing the
IHandlerExceptioncontext (_cache.LastOrDefault()) toOnErrorHandleAsyncfor consistency with the information available to the default error rendering path.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6004 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 670 670
Lines 30620 30620
Branches 4355 4355
=========================================
Hits 30620 30620 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-Authored-By: Jayce Liu <[email protected]>
This reverts commit 75d4f36.
Link issues
fixes #6003
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Enhance the ErrorLogger component to support a custom OnErrorHandleAsync method for more flexible error handling
Bug Fixes:
Enhancements: