Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented May 9, 2025

Link issues

fixes #6003

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Enhance the ErrorLogger component to support a custom OnErrorHandleAsync method for more flexible error handling

Bug Fixes:

  • Fixed issue with custom OnErrorHandleAsync not working correctly on Layout

Enhancements:

  • Added support for custom error handling through OnErrorHandleAsync method
  • Injected ILogger to provide logging capabilities in error handling

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented May 9, 2025

Reviewer's Guide

This pull request updates the ErrorLogger component to enable custom asynchronous error handling. It achieves this by injecting an ILogger and modifying HandlerExceptionAsync to invoke a user-provided OnErrorHandleAsync delegate with the logger and exception, falling back to the original error rendering logic if no custom delegate is set.

File-Level Changes

Change Details Files
Enhanced ErrorLogger to support custom asynchronous error handling via a delegate.
  • Injected ILogger<ErrorLogger> dependency.
  • Made HandlerExceptionAsync an asynchronous method.
  • Modified HandlerExceptionAsync to call a custom OnErrorHandleAsync delegate if provided, passing the logger and exception.
  • Preserved existing error rendering logic as a fallback if OnErrorHandleAsync is not set.
src/BootstrapBlazor/Components/ErrorLogger/ErrorLogger.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#6003 The OnErrorHandleAsync delegate set in the Layout component should be invoked when an error occurs.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the bug Something isn't working label May 9, 2025
@bb-auto bb-auto bot added this to the v9.6.0 milestone May 9, 2025
sourcery-ai[bot]
sourcery-ai bot previously approved these changes May 9, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

  • Invoking OnErrorHandleAsync now prevents the default ErrorBoundary UI from rendering the error; clarify if custom handlers are expected to manage all UI aspects.
  • Consider passing the IHandlerException context (_cache.LastOrDefault()) to OnErrorHandleAsync for consistency with the information available to the default error rendering path.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented May 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7d3ac79) to head (ce0f241).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6004   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          670       670           
  Lines        30620     30620           
  Branches      4355      4355           
=========================================
  Hits         30620     30620           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ArgoZhang ArgoZhang merged commit 56b9907 into main May 9, 2025
5 checks passed
@ArgoZhang ArgoZhang deleted the refactor-error branch May 9, 2025 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(ErrorLogger): Layout 中设置的 OnErrorHandleAsync 不起作用

2 participants