Skip to content

Conversation

@kimdiego2098
Copy link
Collaborator

@kimdiego2098 kimdiego2098 commented May 9, 2025

Link issues

fixes #6007

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Enhancements:

  • Implement fallback mechanism to search for localization resources in parent class assemblies when resources are missing in the current class

@bb-auto
Copy link

bb-auto bot commented May 9, 2025

Thanks for your PR, @kimdiego2098. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented May 9, 2025

Reviewer's Guide

This pull request updates the JsonStringLocalizer to enable fallback resource lookup from parent classes. If a localization string is not found for the current type, the system will now attempt to retrieve it from its base class's JSON language resources.

File-Level Changes

Change Details Files
Implemented fallback mechanism to search for missing localization resources in the parent class.
  • Modified the indexer this[string name] to attempt resource lookup from the base type if the resource is not found in the current type.
  • Added logic to get the property's declaring type and, if it's a base type, load and search its associated localizer strings.
  • Ensured that HandleMissingResourceItem is called if the resource is not found in either the current or base class.
src/BootstrapBlazor/Localization/Json/JsonStringLocalizer.cs

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot requested a review from ArgoZhang May 9, 2025 07:50
sourcery-ai[bot]
sourcery-ai bot previously approved these changes May 9, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kimdiego2098 - I've reviewed your changes - here's some feedback:

  • Consider replacing Assembly.GetType(typeName) with Type.GetType(typeName) for more reliable type resolution across assemblies.
  • When a base class resource is found, assign a new LocalizedString instance to ret, not just the string value, to maintain localization metadata.
  • The condition for calling HandleMissingResourceItem after the base class lookup should be based on whether the lookup succeeded, rather than checking if ret is null.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟡 Complexity: 1 issue found
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented May 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7d3ac79) to head (b326ba2).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6006   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          670       670           
  Lines        30620     30645   +25     
  Branches      4355      4361    +6     
=========================================
+ Hits         30620     30645   +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ArgoZhang
ArgoZhang previously approved these changes May 9, 2025
@ArgoZhang ArgoZhang changed the title 属性自动尝试从父类中获取json语言资源 feat(Localizer): add GetStringFromBaseType logic support base type May 9, 2025
@bb-auto bb-auto bot added the enhancement New feature or request label May 9, 2025
@bb-auto bb-auto bot added this to the v9.6.0 milestone May 9, 2025
@ArgoZhang ArgoZhang merged commit d86aa37 into main May 9, 2025
6 checks passed
@ArgoZhang ArgoZhang deleted the localization_dev branch May 9, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(Localizer): add GetStringFromBaseType logic support base type

3 participants