feat(TableFilter): redesign filter system #6020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's GuideThis PR completely overhauls the table filtering architecture by replacing the old TableFilter with a new TableColumnFilter component, refactoring filter base classes, introducing a generic Filter wrapper, updating all built-in filter components to the new API, adjusting samples, and streamlining the unit tests to align with the simplified OnFilterAsync/Reset model. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
- There are repeated definitions of MockTable and MockColumn across many test classes—consider extracting these into shared test helpers to reduce duplication and make future updates easier.
- The Filter component mixes a lot of inline render logic with dynamic parameter injection—factoring out the RenderFilter delegate or moving the template selection into a dedicated helper could improve readability and maintainability.
- I see many literal SelectedItem lists and hard‐coded filter parameters throughout the code; consider introducing reusable factories or static collections to DRY up these repetitive initializations.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 2 issues found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6020 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 670 701 +31
Lines 30657 30871 +214
Branches 4364 4370 +6
==========================================
+ Hits 30657 30871 +214 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #6012
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Redesign the table filtering system by replacing the old TableFilter with a new TableColumnFilter component and introducing a unified Filter wrapper and MultipleFilterBase for multi‐condition filters. Update filter base classes, component templates, and CascadingParameters to streamline type‐specific filters (string, number, date, enum, bool, lookup, multi). Update sample usage and SCSS imports accordingly. Migrate and simplify unit tests to target the new filter architecture and close #6012.
New Features:
Enhancements:
Tests: