-
-
Notifications
You must be signed in to change notification settings - Fork 364
refactor(IgnoreWhenExport): update AutoGenerateColumnAttribute logic #6023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideRefactors the IgnoreWhenExport logic by converting the property to a non-nullable bool and providing an explicit ITableColumn implementation that defaults null assignments to false, and updates unit tests to cover the new behavior. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6023 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 701 701
Lines 30871 30873 +2
Branches 4370 4370
=========================================
+ Hits 30871 30873 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Link issues
fixes #6009
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Refactor the IgnoreWhenExport property in AutoGenerateColumnAttribute to be non-nullable with explicit interface mapping and add a unit test to verify null assignment behavior
Bug Fixes:
Enhancements:
Tests: