Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented May 14, 2025

Link issues

fixes #6019

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Implement automatic search text clearance and collapse event callback for the Select component by adding new parameters, wiring JS interop hide callback, and updating tests and samples.

New Features:

  • Add IsAutoClearSearchTextWhenCollapsed parameter to Select component to automatically clear search text when collapsed
  • Introduce OnCollapsed callback parameter to notify when dropdown is collapsed

Bug Fixes:

Enhancements:

  • Hook into the JS popover hide callback to invoke the collapse logic
  • Update sample attributes in Selects.razor.cs to include the new parameter

Documentation:

  • Document the new IsAutoClearSearchTextWhenCollapsed parameter in component samples

Tests:

  • Add unit tests verifying OnCollapsed invocation
  • Add unit tests verifying search text is cleared when IsAutoClearSearchTextWhenCollapsed is enabled

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented May 14, 2025

Reviewer's Guide

Adds automatic search text clearing and a collapsed callback to the Select component by introducing two new parameters, wiring a JS hide callback to invoke a Blazor JSInvokable method, updating documentation and tests, and reorganizing the component code.

File-Level Changes

Change Details Files
Introduce IsAutoClearSearchTextWhenCollapsed and OnCollapsed parameters to Select component
  • Added two [Parameter] properties to expose collapse behavior
  • Extended Init() interop setup to include triggerCollapsed when enabled
  • Implemented JSInvokable TriggerCollapsed to clear search text and invoke the callback
Select.razor.cs
Enhance JavaScript to invoke collapse callback
  • Passed hideCallback option into Popover.init
  • hideCallback invokes the Blazor triggerCollapsed method if configured
Select.razor.js
Extend unit tests to verify collapse behavior
  • Added test for OnCollapsed being invoked
  • Added test for IsAutoClearSearchTextWhenCollapsed clearing search input
SelectTest.cs
Document new parameter in sample metadata
  • Added attribute entry for IsAutoClearSearchTextWhenCollapsed in sample component
Selects.razor.cs
Refactor Select.razor.cs structure
  • Reordered injected services and parameter declarations
  • Consolidated explicit interface property implementations
  • Removed duplicated helper methods relocated earlier in file
Select.razor.cs

Assessment against linked issues

Issue Objective Addressed Explanation

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the enhancement New feature or request label May 14, 2025
@bb-auto bb-auto bot added this to the v9.6.0 milestone May 14, 2025
@ArgoZhang ArgoZhang enabled auto-merge (squash) May 14, 2025 08:35
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

  • There are duplicated implementations of GetSelectedRow (and related helper methods) in the file—consolidate them into a single definition to avoid redundancy.
  • The new unit tests call cut.Contains(...) but don’t assert the result; replace those calls with Assert.Contains or Assert.True to actually validate the behavior.
  • The reordering of injected services, parameters, and private members makes the diff noisy—consider grouping definitions (e.g. parameters then injections then private members) for clearer structure.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang ArgoZhang disabled auto-merge May 14, 2025 09:20
@ArgoZhang ArgoZhang merged commit 44c3b45 into main May 14, 2025
4 checks passed
@ArgoZhang ArgoZhang deleted the feat-select branch May 14, 2025 09:20
@codecov
Copy link

codecov bot commented May 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (665d46f) to head (4e73c33).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6024   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          701       701           
  Lines        30873     30888   +15     
  Branches      4370      4373    +3     
=========================================
+ Hits         30873     30888   +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(Select): 能不能在收起搜索框的时候自动清空搜索框的内容

2 participants