-
-
Notifications
You must be signed in to change notification settings - Fork 364
feat(MultipleFilterBase): remove MultipleFilterBase use FilterBase #6033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideDeprecates MultipleFilterBase by migrating its Count and Logic parameters into FilterBase and updating all filter components to inherit FilterBase with English XML comments. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
|
||
| /// <summary> | ||
| /// | ||
| /// DataTime filter component |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (typo): Typo in summary: 'DataTime' should be 'DateTime'
| /// DataTime filter component | |
| /// DateTime filter component |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6033 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 702 701 -1
Lines 30951 30945 -6
Branches 4376 4375 -1
=========================================
- Hits 30951 30945 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6032
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Remove MultipleFilterBase in favor of using FilterBase by migrating shared filter properties and behaviors, deprecating the old class, and updating all filter components to inherit from the consolidated base.
Enhancements: