Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented May 16, 2025

Link issues

fixes #6032

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Remove MultipleFilterBase in favor of using FilterBase by migrating shared filter properties and behaviors, deprecating the old class, and updating all filter components to inherit from the consolidated base.

Enhancements:

  • Deprecate MultipleFilterBase and merge its functionality into FilterBase for unified filter handling
  • Move Count and Logic parameters into FilterBase and update its OnParametersSet method accordingly
  • Update DateTimeFilter, EnumFilter, NumberFilter, and StringFilter components to inherit from FilterBase instead of MultipleFilterBase
  • Add [Obsolete] and [ExcludeFromCodeCoverage] attributes to MultipleFilterBase to signal deprecation

@bb-auto bb-auto bot added the enhancement New feature or request label May 16, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented May 16, 2025

Reviewer's Guide

Deprecates MultipleFilterBase by migrating its Count and Logic parameters into FilterBase and updating all filter components to inherit FilterBase with English XML comments.

File-Level Changes

Change Details Files
Mark MultipleFilterBase as obsolete and remove its redundant filtering logic
  • Add [Obsolete] and [ExcludeFromCodeCoverage] attributes
  • Remove Count property, Logic field, and OnParametersSet override
MultipleFilterBase.cs
Integrate Count and Logic parameters into FilterBase
  • Add Count parameter and Logic property
  • Extend OnParametersSet to assign Count from FilterContext
FilterBase.cs
Switch filter components to inherit from FilterBase and update documentation
  • Change @inherits from MultipleFilterBase to FilterBase
  • Replace Chinese XML comments with English descriptions
DateTimeFilter.razor
DateTimeFilter.razor.cs
EnumFilter.razor
EnumFilter.razor.cs
NumberFilter.razor
NumberFilter.razor.cs
StringFilter.razor
StringFilter.razor.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#6032 Remove the MultipleFilterBase class.
#6032 Replace usages of MultipleFilterBase with FilterBase.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added this to the v9.6.0 milestone May 16, 2025
@ArgoZhang ArgoZhang merged commit 2fec2d0 into main May 16, 2025
4 checks passed
@ArgoZhang ArgoZhang deleted the refactor-filter branch May 16, 2025 01:02
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.


/// <summary>
///
/// DataTime filter component
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (typo): Typo in summary: 'DataTime' should be 'DateTime'

Suggested change
/// DataTime filter component
/// DateTime filter component

@codecov
Copy link

codecov bot commented May 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (356f3b2) to head (a7371bf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6033   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          702       701    -1     
  Lines        30951     30945    -6     
  Branches      4376      4375    -1     
=========================================
- Hits         30951     30945    -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(MultipleFilterBase): remove MultipleFilterBase use FilterBase

2 participants