-
-
Notifications
You must be signed in to change notification settings - Fork 364
feat(Message): support async update content use same option #6040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis PR refactors the toast progress logic to centralize element handling, adds transition‐based hide behavior, and cleans up event listeners, while extending the message component to support asynchronous content updates using a single MessageOption and preventing duplicate messages. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6040 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 701 701
Lines 30955 30958 +3
Branches 4377 4378 +1
=========================================
+ Hits 30955 30958 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6034
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Enable asynchronous message updates by reusing the same MessageOption instance, enhance the Toast JavaScript to maintain a persistent progress element and handle update events consistently, prevent duplicate messages, and add a new async message demo.
New Features:
Bug Fixes:
Enhancements: