refactor(Toast): update javascript logic

[ArgoZhang]

Link issues

fixes #6038 #6034 #6036

Summary By Copilot

Regression?

• Yes
• No

Risk

• High
• Medium
• Low

Verification

• Manual (required)
• Automated

Packaging changes reviewed?

• Yes
• No
• N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

• Doc is updated/provided or not needed
• Demo is updated/provided or not needed
• Merge the latest code from the main branch

Summary by Sourcery

Refactor toast JavaScript logic to correct autohide behavior and remove redundant configuration updates

Bug Fixes:

• Conditionally hide the toast only when autohide is disabled after transition end

Enhancements:

• Remove redundant autohide configuration assignment in the update() method

[sourcery-ai]

Reviewer's Guide

Enhanced the Toast component’s JavaScript by conditionally hiding toasts only when autohide is disabled and removing an unnecessary reconfiguration of the autohide setting during updates.

File-Level Changes

Change	Details	Files
Conditional hide invocation on transition end based on autohide flag	Wrapped the hide() call in an if check for _config.autohide === false	src/BootstrapBlazor/Components/Toast/Toast.razor.js
Removed redundant autohide property assignment in update function	Deleted the toast._config.autohide = autoHide; assignment to prevent redundant updates	src/BootstrapBlazor/Components/Toast/Toast.razor.js

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#6038	Perfect the AutoHide logic of the Toast component.	✅

Possibly linked issues

• refactor(Toast): perfect AutoHide logic #6038: The PR updates the autohide JavaScript logic in Toast.razor.js to fix the issue.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

• The transitionend handler now only hides toasts when autohide is false, which inverts the expected behavior and will prevent automatic dismissal when autohide is true.
• The update function no longer synchronizes the autohide setting into toast._config, leading to mismatches between the DOM attributes and the toast’s internal state.
• Accessing the private _config property may be fragile—consider using or extending the public API for updating toast configuration instead of touching internal fields directly.

Here's what I looked at during the review

• 🟡 General issues: 2 issues found
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

issue (bug_risk): Reverse autohide logic: only hide on manual dismiss

Invert the condition so toast.hide() runs when _config.autohide is true instead of false.

[sourcery-ai]

suggestion (bug_risk): Restore updating autohide in update method

Without that assignment, changes to data-bs-autohide won’t update the toast instance, causing stale behavior. Re-add it or otherwise sync autohide on update.

Suggested change

	const delay = parseInt(element.getAttribute('data-bs-delay'));
	const autoHide = element.getAttribute('data-bs-autohide') !== 'false';
	toast._config.autohide = autoHide;

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d5cbb73) to head (4d484f8).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main     #6042   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          701       701           
  Lines        30958     30958           
  Branches      4378      4378           
=========================================
  Hits         30958     30958           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.