Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented May 18, 2025

Link issues

fixes #6047

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Remove an outdated GitHub Actions workflow, improve build workflow formatting, and introduce new CI test steps for router and localization validation.

CI:

  • Remove stale 'close-stale-issues' GitHub Actions workflow
  • Clean up whitespace and formatting in the build workflow
  • Add 'Check Router' and 'Check Localizer' steps to CI pipeline

Tests:

  • Run UnitTestDocs and UnitTestLocalization as part of CI

@bb-auto bb-auto bot added the chore This are tasks or bot action label May 18, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented May 18, 2025

Reviewer's Guide

This PR refines the CI pipeline by tidying up the build workflow YAML, adding two new unit-test steps for routing and localization, and removes an outdated stale-issues workflow.

Flowchart: Updated 'build' Job in build.yml

graph TD
    Start([Start 'build' job]) --> Checkout["Step: actions/checkout@v4"];
    Checkout --> SetupDotNet["Step: actions/setup-dotnet@v4<br/>(.NET 9.0.x)"];
    SetupDotNet --> Build["Step: Build<br/>(dotnet build, pack, nuget push)"];
    Build --> Codecov["Step: codecov/codecov-action@v4"];
    Codecov --> CheckRouter["Step: Check Router (New)<br/>(dotnet test test/UnitTestDocs)"];
    CheckRouter --> CheckLocalizer["Step: Check Localizer (New)<br/>(dotnet test test/UnitTestLocalization)"];
    CheckLocalizer --> End([End 'build' job]);

    style CheckRouter fill:#e6ffe6,stroke:#006400,stroke-width:2px;
    style CheckLocalizer fill:#e6ffe6,stroke:#006400,stroke-width:2px;
Loading

File-Level Changes

Change Details Files
Added new test steps and cleaned up YAML formatting in build workflow
  • Removed trailing whitespace and standardized indentation
  • Normalized 'env' block formatting under Build step
  • Added 'Check Router' step to run routing tests
  • Added 'Check Localizer' step to run localization tests
.github/workflows/build.yml
Removed the stale close-stale-issues GitHub Actions workflow
  • Deleted the unused stale-issues workflow configuration
.github/workflows/close-stale-issues.yml

Assessment against linked issues

Issue Objective Addressed Explanation
#6047 Remove the stale action workflow file.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added this to the v9.6.0 milestone May 18, 2025
@ArgoZhang ArgoZhang merged commit 1b75d1c into main May 18, 2025
3 checks passed
@ArgoZhang ArgoZhang deleted the chore-action branch May 18, 2025 03:17
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

  • The PR description still contains unused template sections—please remove or fill them out to keep the description concise and meaningful.
  • You’ve added separate steps for Router and Localizer tests—consider merging these into a single testing job (or matrix) to reduce repetition and simplify maintenance.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented May 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (cd681ef) to head (0d6fd20).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6048   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          701       701           
  Lines        30958     30958           
  Branches      4378      4378           
=========================================
  Hits         30958     30958           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore This are tasks or bot action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(Action): remove stale action

2 participants