-
-
Notifications
You must be signed in to change notification settings - Fork 364
doc(Reconnector): update support sdk version #6051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis PR updates sample component documentation to include .NET9 support and corrects the input demo block’s Name attribute. File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates UI samples to include .NET9 support and corrects a demo block identifier.
- Adds “NET9” to the supported SDK version list in reconnect component samples
- Renames the
Nameattribute for the clearable input demo fromOnInputtoIsClearable
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/BootstrapBlazor.Server/Components/Samples/Reconnectors.razor | Updated displayed SDK versions to include NET9 |
| src/BootstrapBlazor.Server/Components/Samples/Inputs.razor | Renamed demo block Name from “OnInput” to “IsClearable” |
| src/BootstrapBlazor.Server/Components/Components/BlazorReconnector.razor | Updated displayed SDK versions to include NET9 |
Comments suppressed due to low confidence (1)
src/BootstrapBlazor.Server/Components/Samples/Inputs.razor:227
- [nitpick] Confirm that the
Namevalue matches the actual demo snippet filename (e.g.IsClearable.razor) to ensure the correct sample is loaded.
Name="IsClearable">
| <div class="flex-fill"> | ||
| <p>基于 <b>Bootstrap</b> 样式的 <b>Blazor UI</b> 组件库</p> | ||
| <p>适配移动端支持各种主流浏览器,适配 <b>ABP</b>,同时支持 <b>NET6/NET7/NET8</b>,交流群 <b>795206915</b></p> | ||
| <p>适配移动端支持各种主流浏览器,适配 <b>ABP</b>,同时支持 <b>NET6/NET7/NET8/NET9</b>,交流群 <b>795206915</b></p> |
Copilot
AI
May 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] This version-support string is repeated multiple times. Consider extracting the supported SDK versions into a shared constant or resource to avoid manual updates in every sample section.
| <div class="flex-fill"> | ||
| <p>一套基于 <b>Bootstrap</b> 样式的企业级 <b>Blazor UI</b> 组件库,支持 Server 与 WebAssembly</p> | ||
| <p>适配移动端支持各种主流浏览器以及移动端,适配 <b>ABP</b>,同时支持 <b>NET6/NET7/NET8</b></p> | ||
| <p>适配移动端支持各种主流浏览器以及移动端,适配 <b>ABP</b>,同时支持 <b>NET6/NET7/NET8/NET9</b></p> |
Copilot
AI
May 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Duplicate version text here suggests centralizing the SDK support list (e.g., in a shared constant or localized resource) to keep version updates in sync across components.
| <p>适配移动端支持各种主流浏览器以及移动端,适配 <b>ABP</b>,同时支持 <b>NET6/NET7/NET8/NET9</b></p> | |
| <p>适配移动端支持各种主流浏览器以及移动端,适配 <b>ABP</b>,同时支持 <b>@SupportedDotNetVersions</b></p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6051 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 701 701
Lines 30958 30958
Branches 4378 4378
=========================================
Hits 30958 30958 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6050
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Include .NET 9 in the supported SDK versions across reconnectors samples and correct the clearable input demo naming in the Inputs sample.
Bug Fixes:
Enhancements: