Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented May 18, 2025

Link issues

fixes #6050

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Include .NET 9 in the supported SDK versions across reconnectors samples and correct the clearable input demo naming in the Inputs sample.

Bug Fixes:

  • Rename the DemoBlock Name attribute from "OnInput" to "IsClearable" in the clearable input sample.

Enhancements:

  • Update Reconnectors.razor and BlazorReconnector.razor components to list NET9 in supported SDK versions alongside NET6/NET7/NET8.

@bb-auto bb-auto bot added the documentation Improvements or additions to documentation label May 18, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented May 18, 2025

Reviewer's Guide

This PR updates sample component documentation to include .NET9 support and corrects the input demo block’s Name attribute.

File-Level Changes

Change Details Files
Extend supported .NET version mentions to include NET9 in sample components
  • Replaced version list in markup paragraphs to include NET9 (plain and HTML-encoded) across samples
src/BootstrapBlazor.Server/Components/Samples/Reconnectors.razor
src/BootstrapBlazor.Server/Components/Components/BlazorReconnector.razor
Rename sample input demo block attribute
  • Changed DemoBlock Name property from OnInput to IsClearable
src/BootstrapBlazor.Server/Components/Samples/Inputs.razor

Assessment against linked issues

Issue Objective Addressed Explanation
#6050 Update the documentation to reflect the supported SDK versions for the Reconnector component.
#6050 Add sample code for the Reconnector component. The issue body requests adding sample code for the component, but the PR only updates the supported SDK versions in the documentation. No sample code is added.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added this to the v9.6.0 milestone May 18, 2025
@ArgoZhang ArgoZhang requested a review from Copilot May 18, 2025 04:24
@ArgoZhang ArgoZhang merged commit df12986 into main May 18, 2025
4 checks passed
@ArgoZhang ArgoZhang deleted the doc-reconnector branch May 18, 2025 04:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates UI samples to include .NET9 support and corrects a demo block identifier.

  • Adds “NET9” to the supported SDK version list in reconnect component samples
  • Renames the Name attribute for the clearable input demo from OnInput to IsClearable

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/BootstrapBlazor.Server/Components/Samples/Reconnectors.razor Updated displayed SDK versions to include NET9
src/BootstrapBlazor.Server/Components/Samples/Inputs.razor Renamed demo block Name from “OnInput” to “IsClearable”
src/BootstrapBlazor.Server/Components/Components/BlazorReconnector.razor Updated displayed SDK versions to include NET9
Comments suppressed due to low confidence (1)

src/BootstrapBlazor.Server/Components/Samples/Inputs.razor:227

  • [nitpick] Confirm that the Name value matches the actual demo snippet filename (e.g. IsClearable.razor) to ensure the correct sample is loaded.
Name="IsClearable">

<div class="flex-fill">
<p>基于 <b>Bootstrap</b> 样式的 <b>Blazor UI</b> 组件库</p>
<p>适配移动端支持各种主流浏览器,适配 <b>ABP</b>同时支持 <b>NET6/NET7/NET8</b>交流群 <b>795206915</b></p>
<p>适配移动端支持各种主流浏览器,适配 <b>ABP</b>同时支持 <b>NET6/NET7/NET8/NET9</b>交流群 <b>795206915</b></p>
Copy link

Copilot AI May 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] This version-support string is repeated multiple times. Consider extracting the supported SDK versions into a shared constant or resource to avoid manual updates in every sample section.

Copilot uses AI. Check for mistakes.
<div class="flex-fill">
<p>一套基于 <b>Bootstrap</b> 样式的企业级 <b>Blazor UI</b> 组件库,支持 Server 与 WebAssembly</p>
<p>适配移动端支持各种主流浏览器以及移动端,适配 <b>ABP</b>,同时支持 <b>NET6/NET7/NET8</b></p>
<p>适配移动端支持各种主流浏览器以及移动端,适配 <b>ABP</b>,同时支持 <b>NET6/NET7/NET8/NET9</b></p>
Copy link

Copilot AI May 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Duplicate version text here suggests centralizing the SDK support list (e.g., in a shared constant or localized resource) to keep version updates in sync across components.

Suggested change
<p>适配移动端支持各种主流浏览器以及移动端,适配 <b>ABP</b>,同时支持 <b>NET6/NET7/NET8/NET9</b></p>
<p>适配移动端支持各种主流浏览器以及移动端,适配 <b>ABP</b>,同时支持 <b>@SupportedDotNetVersions</b></p>

Copilot uses AI. Check for mistakes.
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented May 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (1b75d1c) to head (8295b23).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6051   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          701       701           
  Lines        30958     30958           
  Branches      4378      4378           
=========================================
  Hits         30958     30958           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

doc(Reconnector): update support sdk version

2 participants