feat(Meeting): add Meeting component #6092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's GuideThis PR adds a new “Meet” demo component powered by JitsiMeet by integrating it into the demo menu, updating localization and docs, introducing the package dependency, and providing both markup and code-behind for the sample with event callbacks and command execution. Sequence Diagram for RunCommand Interaction in Meets ComponentsequenceDiagram
actor User
participant MeetsPage as "Meets.razor (UI)"
participant MeetsComponent as "Meets (Component)"
participant MeetService as "Meet (JitsiMeet Component)"
User->>MeetsPage: Clicks "Execute Command" button
MeetsPage->>MeetsComponent: RunCommand()
MeetsComponent->>MeetService: ExecuteCommand("toggleChat")
Class Diagram for the new Meets ComponentclassDiagram
class ComponentBase {
<<abstract>>
}
class Meets {
- _option: MeetOption
- _meet: Meet
- _domain: string
+ ToastService: ToastService
+ OnInitialized() void
+ OnLoad() void
+ RunCommand() Task
}
class MeetOption {
+ RoomName: string
+ Width: string
+ Height: int
+ ConfigOverwrite: object
+ UserInfo: UserInfo
}
class UserInfo {
+ DisplayName: string
+ Email: string
}
class Meet {
+ ExecuteCommand(string commandName) Task
}
class ToastService {
+ Information(string title, string message) void
}
Meets --|> ComponentBase
Meets o-- MeetOption
Meets o-- Meet
Meets ..> ToastService : uses
MeetOption o-- UserInfo
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6092 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 701 701
Lines 30968 30968
Branches 4380 4380
=========================================
Hits 30968 30968 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| <DemoBlock Title="使用JitsiMeet创建会议室" Introduction="使用JitsiMeet创建会议室，支持执行命令，支持OnLoad回调（meet.jit.si不会触发回调也不会响应命令，请使用8x8.vc或子托管域名测试）。例子中隐藏了内置的邀请程序，无法在会议中找到邀请链接。" Name="Normal"> | ||
| <section class="row form-inline g-3"> | ||
| <div class="col-12 col-sm-6"> | ||
| <Display Value="_domain" DisplayText="服务器地址" ShowLabel="true"></Display> |
Contributor
There was a problem hiding this comment.
issue (bug_risk): Use @-prefixed C# binding for Value parameter
Value="_domain" sets the parameter to the string "_domain" instead of the variable's value. Use Value="@_domain" to bind the variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #6091
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add a JitsiMeet-based Meet component with a corresponding demo page and menu entry
New Features:
Build:
Documentation: