Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented May 28, 2025

Link issues

fixes #6105

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Add HeaderPaddingY parameter to Card component to allow customizing header vertical padding via CSS variable

New Features:

  • Introduce HeaderPaddingY parameter for Card to specify header padding on the Y axis

Enhancements:

  • Apply HeaderPaddingY value by setting the --bs-card-cap-padding-y CSS variable on the card root element

Documentation:

  • Document HeaderPaddingY in card samples and update localization entries for the new parameter

@bb-auto bb-auto bot added the enhancement New feature or request label May 28, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented May 28, 2025

Reviewer's Guide

Adds a new HeaderPaddingY parameter to the Card component that exposes a CSS custom property (--bs-card-cap-padding-y) for controlling the vertical padding of the card header; includes binding in the markup, sample docs update, and localization entries.

Updated Class Diagram for Card Component

classDiagram
  class Card {
    +string? HeaderPaddingY [Parameter]
    -string? HeaderStyleString [Computed]
  }
Loading

File-Level Changes

Change Details Files
Introduce HeaderPaddingY parameter and CSS style builder
  • Define public string? HeaderPaddingY with XML doc
  • Create private HeaderStyleString using CssBuilder to map HeaderPaddingY to --bs-card-cap-padding-y
src/BootstrapBlazor/Components/Card/Card.razor.cs
Bind the new padding parameter in the Card markup
  • Add style="@HeaderStyleString" to the root
  • Reorder id and class attributes to include the style binding
src/BootstrapBlazor/Components/Card/Card.razor
Update sample attribute table to include HeaderPaddingY
  • Insert new AttributeItem entry for HeaderPaddingY in Samples/Cards.razor.cs
src/BootstrapBlazor.Server/Components/Samples/Cards.razor.cs
Add localization keys for HeaderPaddingY
  • Add "HeaderPaddingY" entry in en-US.json
  • Add "HeaderPaddingY" entry in zh-CN.json
src/BootstrapBlazor.Server/Locales/en-US.json
src/BootstrapBlazor.Server/Locales/zh-CN.json

Assessment against linked issues

Issue Objective Addressed Explanation
#6105 Add a HeaderPaddingY parameter to the Card component.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added this to the v9.6.0 milestone May 28, 2025
sourcery-ai[bot]
sourcery-ai bot previously approved these changes May 28, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2ba3fc8) to head (7a63f55).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6106   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          703       703           
  Lines        31026     31019    -7     
  Branches      4387      4386    -1     
=========================================
- Hits         31026     31019    -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ArgoZhang ArgoZhang merged commit 4ad4ea4 into main May 28, 2025
5 checks passed
@ArgoZhang ArgoZhang deleted the feat-card branch May 28, 2025 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(Card): add HeaderPaddingY parameter

2 participants