-
-
Notifications
You must be signed in to change notification settings - Fork 363
feat(Card): add HeaderPaddingY parameter #6106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideAdds a new HeaderPaddingY parameter to the Card component that exposes a CSS custom property (--bs-card-cap-padding-y) for controlling the vertical padding of the card header; includes binding in the markup, sample docs update, and localization entries. Updated Class Diagram for Card ComponentclassDiagram
class Card {
+string? HeaderPaddingY [Parameter]
-string? HeaderStyleString [Computed]
}
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6106 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 703 703
Lines 31026 31019 -7
Branches 4387 4386 -1
=========================================
- Hits 31026 31019 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6105
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add HeaderPaddingY parameter to Card component to allow customizing header vertical padding via CSS variable
New Features:
Enhancements:
Documentation: