feat(SelectGeneric): add reset logic when TextConvertToValueCallback return null

[ArgoZhang]

Link issues

fixes #6120

Summary By Copilot

Regression?

• Yes
• No

Risk

• High
• Medium
• Low

Verification

• Manual (required)
• Automated

Packaging changes reviewed?

• Yes
• No
• N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

• Doc is updated/provided or not needed
• Demo is updated/provided or not needed
• Merge the latest code from the main branch

Summary by Sourcery

Implement fallback logic in SelectGeneric to discard invalid text conversions and reset the displayed input value when the conversion callback returns null

New Features:

• Reset the input display when TextConvertToValueCallback returns null

Enhancements:

• Allow TextConvertToValueCallback to return null by updating its signature to Task<TValue?>
• Add a JavaScript resetValue method and invoke it to restore the previous display on null conversions
• Remove tabindex attribute from the display template container

Tests:

• Add unit tests to cover scenarios where TextConvertToValueCallback returns null and ensure no state change

[sourcery-ai]

Reviewer's Guide

This PR augments SelectGeneric to properly handle null conversions from the editable input by updating the callback signature to allow nullable returns, branching on null to invoke a JS reset helper, and ensuring markup and tests align with the new behavior.

Sequence Diagram for Reset Logic on Null TextConvertToValueCallback Result

sequenceDiagram
    actor User
    participant SG as SelectGeneric.razor.cs
    participant TCVCallback as TextConvertToValueCallback
    participant JS as Select.razor.js (JS Interop)

    User->>SG: Inputs text in editable Select & blurs (triggers OnChange)
    SG->>TCVCallback: await TextConvertToValueCallback(inputText)
    TCVCallback-->>SG: return null
    SG->>JS: InvokeVoidAsync("resetValue", InputId, PreviousSelectedText)
    JS->>JS: document.getElementById(InputId).value = PreviousSelectedText

Loading

Updated Class Diagram for SelectGeneric

classDiagram
    class SelectGeneric~TValue~ {
        +TextConvertToValueCallback: Func~string, Task~TValue?~~
        #OnChange(ChangeEventArgs args) Task
    }

Loading

File-Level Changes

Change	Details	Files
Allow TextConvertToValueCallback to return null and update conversion flow	Changed callback type to Func<string, Task<TValue?>>? Adjusted OnChange handler to check for null result Branch: add new item on non-null, reset input on null	SelectGeneric.razor.cs
Introduce resetValue JS helper and invoke on null conversion	Implemented resetValue function in Select.razor.js Invoke resetValue via JS interop when conversion yields null	Select.razor.js SelectGeneric.razor.cs
Streamline component markup by removing tabindex	Removed tabindex="0" from display div to simplify focus handling	SelectGeneric.razor
Extend and adjust unit tests for null-return scenario	Added tests covering null callback path and reset logic Applied non-null assertions (v!) for existing callback returns	SelectGenericTest.cs

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#6120	When SelectGeneric is enabled with IsEditable, if the input is invalid, it should revert to the original input content.	✅

Possibly linked issues

• feat(SelectGeneric): 增加 IsEditable=true 的情况下输入不合法还原的能力 #6120: The PR implements the fix for issue 6120 by adding input reset logic when the TextConvertToValueCallback returns null.
• feat(SelectGeneric): 增加 IsEditable=true 的情况下输入不合法还原的能力 #6120: The PR fixes the issue by adding reset logic and handling null values in the Select component, addressing the problem of re-selecting values after clearing.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @ArgoZhang - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟡 General issues: 1 issue found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (dae37ad) to head (e0e5f12).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main     #6123   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          703       703           
  Lines        31053     31059    +6     
  Branches      4392      4394    +2     
=========================================
+ Hits         31053     31059    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[ArgoZhang]

@sourcery-ai review

[sourcery-ai]

Hey @ArgoZhang - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟡 Testing: 1 issue found
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}