-
-
Notifications
You must be signed in to change notification settings - Fork 363
feat(SelectTree): add CanExpandWhenDisabled parameter #6128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis PR adds a new boolean parameter CanExpandWhenDisabled to the SelectTree component, allowing tree nodes to be expanded or collapsed even when the component is disabled (defaulting to false). Sequence Diagram: Conditional Node Expansion/Collapse in Disabled SelectTreesequenceDiagram
actor User
participant ST as SelectTree
participant TV as TreeView
User->>ST: Clicks node (ST is disabled)
ST->>TV: Forwards interaction (TreeView configured with ST.CanExpandWhenDisabled)
alt TreeView.CanExpandWhenDisabled is true
TV->>TV: Process expand/collapse node
TV-->>ST: Update view / state
ST-->>User: Node visually expands/collapses
else TreeView.CanExpandWhenDisabled is false
TV->>TV: Block expand/collapse node
TV-->>ST: No view / state update
ST-->>User: Node does not expand/collapse
end
Class Diagram: Update to SelectTree ComponentclassDiagram
class SelectTree~TValue~ {
+bool CanExpandWhenDisabled
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Thanks for your PR, @WilliamLiu1997. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @WilliamLiu1997 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
@WilliamLiu1997 感谢提交 PR 帮忙右上角点一下 star 如果没加社区可以 QQ 群搜 795206915 加入一下。PR 需要弄一个 Issue 写清楚遇到了什么问题,PR 是解决这个问题的。方便维护与跟踪。非常感谢您的参与。 请再回复里键入,签署 CLA 协议
|
Co-Authored-By: WilliamLiu1997 <[email protected]>
|
@WilliamLiu1997 Issue 我已经关联好啦,直接回复里键入
即可自动合并 PR 了 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6128 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 703 703
Lines 31119 31120 +1
Branches 4399 4399
=========================================
+ Hits 31119 31120 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@microsoft-github-policy-service agree |
Link issues
fixes #6153
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
New Features: