feat(IErrorLogger): redesign parameter data type #6132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's GuideThis PR refactors the ErrorLogger feature to use nullable parameters with fallback to global configuration, simplifies the Layout component by removing duplicate option injections, and updates related interface definitions and tests accordingly. Sequence Diagram: ErrorLogger Option Resolution LogicsequenceDiagram
participant EL as ErrorLogger
participant OptsMon as "IOptionsMonitor<BootstrapBlazorOptions>"
participant OptsVal as "BootstrapBlazorOptions.CurrentValue"
EL->>EL: Read local EnableErrorLogger (bool?)
alt local EnableErrorLogger is not null
EL->>EL: Set _enableErrorLogger = local value
else local EnableErrorLogger is null
EL->>OptsMon: Get CurrentValue
OptsMon-->>OptsVal: options instance
EL->>OptsVal: Read EnableErrorLogger property
OptsVal-->>EL: globalEnableErrorLogger (bool)
EL->>EL: Set _enableErrorLogger = global value
end
EL->>EL: Read local ShowToast (bool?)
alt local ShowToast is not null
EL->>EL: Set _showToast = local value
else local ShowToast is null
EL->>OptsMon: Get CurrentValue
OptsMon-->>OptsVal: options instance
EL->>OptsVal: Read ShowErrorLoggerToast property
OptsVal-->>EL: globalShowToast (bool)
EL->>EL: Set _showToast = global value
end
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+65
to
+67
| [Inject] | ||
| [NotNull] | ||
| private IOptionsMonitor<BootstrapBlazorOptions>? Options { get; set; } |
Contributor
There was a problem hiding this comment.
suggestion: Consider making the injected Options property non-nullable
You can remove the '?' from IOptionsMonitor since [NotNull] ensures it won't be null.
Suggested change
| [Inject] | |
| [NotNull] | |
| private IOptionsMonitor<BootstrapBlazorOptions>? Options { get; set; } | |
| [Inject] | |
| [NotNull] | |
| private IOptionsMonitor<BootstrapBlazorOptions> Options { get; set; } |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6132 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 703 703
Lines 31073 31073
Branches 4397 4397
=========================================
Hits 31073 31073 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #6131
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Redesign error-logging parameters to support nullable values and fallback to global configuration settings
Enhancements: