-
-
Notifications
You must be signed in to change notification settings - Fork 363
refactor(Tab): remove ShowErrorLoggerToast parameter #6150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis PR refactors the Tab component by removing the obsolete ShowErrorLoggerToast parameter (and related bindings), enforcing no-toast error logging for Tab items, and standardizing internal tab collection usage by replacing all Items references with TabItems. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6150 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 703 703
Lines 31103 31108 +5
Branches 4399 4398 -1
=========================================
+ Hits 31103 31108 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6149
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Remove the ShowErrorLoggerToast parameter from the Tab component and layout, disable toast display for error logging in tab items, and consolidate tab item handling to use the TabItems collection.
Enhancements: