Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Jun 4, 2025

Link issues

fixes #6149

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Remove the ShowErrorLoggerToast parameter from the Tab component and layout, disable toast display for error logging in tab items, and consolidate tab item handling to use the TabItems collection.

Enhancements:

  • Remove the ShowErrorLoggerToast parameter and related layout attribute from the Tab component
  • Always disable error-toast display in TabItemContent by setting ShowToast to false
  • Replace all usages of the Items collection with the TabItems property in tab rendering, activation, navigation, and drag operations
  • Simplify default-tab rendering logic and ensure consistent TabItems-based traversal

@bb-auto bb-auto bot added the enhancement New feature or request label Jun 4, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jun 4, 2025

Reviewer's Guide

This PR refactors the Tab component by removing the obsolete ShowErrorLoggerToast parameter (and related bindings), enforcing no-toast error logging for Tab items, and standardizing internal tab collection usage by replacing all Items references with TabItems.

File-Level Changes

Change Details Files
Eliminate ShowErrorLoggerToast parameter and enforce no-toast error logging
  • Deleted ShowErrorLoggerToast parameter and its XML docs in Tab.razor.cs
  • Removed ShowErrorLoggerToast binding from Layout.razor
  • Hard-coded ErrorLogger.ShowToast to false in TabItemContent’s RenderItemContent
src/BootstrapBlazor/Components/Tab/Tab.razor.cs
src/BootstrapBlazor/Components/Tab/TabItemContent.cs
src/BootstrapBlazor/Components/Layout/Layout.razor
Standardize tab item collection usage by replacing Items with TabItems
  • Updated AddTabByUrl, ClickPrevTab, DragItemCallback to use TabItems
  • Modified RenderTabList, RenderTabItems, and Tab.razor iteration/finding logic to reference TabItems
  • Replaced .Any()/FirstOrDefault calls on Items with TabItems equivalents
src/BootstrapBlazor/Components/Tab/Tab.razor.cs
src/BootstrapBlazor/Components/Tab/Tab.razor

Assessment against linked issues

Issue Objective Addressed Explanation
#6149 Remove the ShowErrorLoggerToast parameter from the Tab component.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added this to the 9.7.0 milestone Jun 4, 2025
@ArgoZhang ArgoZhang merged commit 4640cae into main Jun 4, 2025
3 checks passed
@ArgoZhang ArgoZhang deleted the refactor-tabitem branch June 4, 2025 05:20
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Jun 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3167b47) to head (3a99a83).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6150   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          703       703           
  Lines        31103     31108    +5     
  Branches      4399      4398    -1     
=========================================
+ Hits         31103     31108    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(Tab): remove ShowErrorLoggerToast parameter

2 participants