-
-
Notifications
You must be signed in to change notification settings - Fork 363
doc(Login): add microsoft login template #6162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit introduces a new `TransitionalLogin.razor` page featuring a structured login form with email and password fields, including validation for the email input and a back button for navigation. The corresponding CSS file, `TransitionalLogin.razor.css`, styles the login interface with background images, button styles, and animations. Additionally, the `TutorialsNavMenu.razor.cs` file is updated to include the new transitional login entry in the navigation menu.
Updated `TransitionalLogin.razor` to replace SVG icons with Font Awesome icons, modified button labels and subtitles to reflect BootstrapBlazor accounts, and switched to `BootstrapInput` components for email and password fields. Retained error message logic. Adjusted CSS in `TransitionalLogin.razor.css` to use `::deep` selectors for scoped styles while maintaining button hover effects.
Removed SVG logo, added "BootstrapBlazor" header, and updated documentation link. Adjusted background image properties for better scaling and introduced new `.blazor-text` class for styling. Centered logo in the layout.
|
Thanks for your PR, @h2ls. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Reviewer's GuideThis PR adds a new "TransitionalLogin" tutorial to the TutorialsNavMenu by defining its menu entry and file list, and introduces two new sample files—a Razor component implementing a two-step login flow with Blazor logic and a corresponding CSS stylesheet for styling and animations. Class Diagram for New and Updated Components in Transitional Login FeatureclassDiagram
class TutorialsNavMenu {
- _template5 : string[]
# OnInitializedAsync() : Task
}
note for TutorialsNavMenu "New field: _template5 (file list for TransitionalLogin tutorial)\nModified method: OnInitializedAsync() to add a new menu item for 'TransitionalLogin' using _template5."
class TransitionalLogin {
<<Razor Component>>
- isEmailEntered : bool
- email : string
- password : string
- showEmailError : bool
- OnEmailSubmit() : void
- GoBack() : void
}
note for TransitionalLogin "New Razor component implementing a two-step login UI.\n- Properties manage the state of the login form (e.g., if email is entered, error display).\n- Methods handle form submissions (OnEmailSubmit) and navigation (GoBack)."
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @h2ls - I've reviewed your changes and found some issues that need to be addressed.
Blocking issues:
- Invalid C# array initialization syntax (link)
- Invalid spread operator usage in array initializer (link)
- Missing click handler for password submission (link)
Here's what I looked at during the review
- 🔴 General issues: 3 blocking issues, 1 other issue
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
...BootstrapBlazor.Server/Components/Samples/Tutorials/LoginAndRegister/TransitionalLogin.razor
Outdated
Show resolved
Hide resolved
...BootstrapBlazor.Server/Components/Samples/Tutorials/LoginAndRegister/TransitionalLogin.razor
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6162 +/- ##
=======================================
Coverage 99.99% 99.99%
=======================================
Files 704 704
Lines 31099 31099
Branches 4395 4395
=======================================
Hits 31098 31098
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6161
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add a new TransitionalLogin tutorial template with accompanying Razor component and CSS, and register it in the tutorials navigation for download.
New Features:
Enhancements: