-
-
Notifications
You must be signed in to change notification settings - Fork 363
feat(PdfViewer): add PdfViewer component #6164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideIntroduces a new PdfViewer component by registering it in the application menu, updating server project references, extending localization and documentation entries, and providing a sample page with full code-behind implementation. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
- Rename PdfViewers.razor (and its code‐behind class) to singular PdfViewer to align file names, route ("/pdf-viewer"), component name, and localization keys.
- Add bounds checks in ApplyPagePrevious/ApplyPageNext to ensure Page never falls below 1 (or exceeds total pages) before calling Refresh.
- Extract the repetitive switch logic in ApplyZoom and ApplyPageMode into reusable helper methods or data-driven mappings to reduce boilerplate.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6164 +/- ##
=======================================
Coverage 99.99% 99.99%
=======================================
Files 704 704
Lines 31099 31099
Branches 4395 4395
=======================================
Hits 31098 31098
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6163
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Introduce a new PdfViewer component for rendering PDF documents, including a demo page in the application menu, localization, and documentation updates.
New Features:
/pdf-viewer) showcasing PdfViewer usage with interactive configurationEnhancements:
Documentation: