feat(PdfViewer): add UseGoogleDocs parameter #6170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's GuideIntroduce a Sequence Diagram for Toggling UseGoogleDocs OptionsequenceDiagram
actor User
participant Switch
participant PdfViewersPage as "PdfViewers.razor Page"
participant PdfViewerComponent as "PdfViewer Component"
User->>Switch: Toggles 'UseGoogleDocs' switch
Switch->>PdfViewersPage: Updates _useGoogleDocs value via @bind-Value
alt Re-render
PdfViewersPage->>PdfViewerComponent: Passes new UseGoogleDocs=@_useGoogleDocs value
PdfViewerComponent->>PdfViewerComponent: (Internally) Re-renders PDF with new setting
end
Class Diagram for PdfViewer Component ChangesclassDiagram
class PdfViewers {
-ToastService toastService
-_useGoogleDocs: bool
+OnLoaded(): Task
+NotSupportCallback(): Task
}
class PdfViewer {
+Url: string
+Height: string
+NotSupportCallback: EventCallback
+OnLoaded: EventCallback
+UseGoogleDocs: bool
}
PdfViewers ..> PdfViewer : uses and configures
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 3 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| <PackageTips Name="BootstrapBlazor.PdfViewer" /> | ||
|
|
||
| <DemoBlock Title="@Localizer["PdfViewerNormalTitle"]" Introduction="@Localizer["PdfViewerNormalIntro"]" Name="Normal"> | ||
| <section ignore> |
Contributor
There was a problem hiding this comment.
suggestion: Using a non-standard ignore attribute may not behave as expected
Consider replacing the non-standard ignore attribute with an @if block, a CSS class like d-none, or a framework-supported directive to control visibility.
Suggested implementation:
<section class="d-none">
<div class="row g-3">
<div class="col-12 col-sm-6">
If you want to control the visibility dynamically, you can use an @if block or bind the class to a variable. For example:
@if (showSection)
{
<section>
...
</section>
}
or
<section class="@(showSection ? "" : "d-none")">
...
</section>
Replace showSection with your actual condition.
| <div class="row g-3"> | ||
| <div class="col-12 col-sm-6"> | ||
| <BootstrapInputGroup> | ||
| <BootstrapInputGroupLabel DisplayText="UseGoogleDocs"></BootstrapInputGroupLabel> |
Contributor
There was a problem hiding this comment.
suggestion: Label text should be localized
Use the Localizer for the label text to support localization, e.g., DisplayText="@localizer["UseGoogleDocs"]".
Suggested change
| <BootstrapInputGroupLabel DisplayText="UseGoogleDocs"></BootstrapInputGroupLabel> | |
| <BootstrapInputGroupLabel DisplayText="@Localizer["UseGoogleDocs"]"></BootstrapInputGroupLabel> |
|
|
||
| private bool _useGoogleDocs = true; | ||
|
|
||
| private Task OnLoaded() => ToastService.Success("Pdf Viewer", Localizer["PdfViewerToastSuccessfulContent"]); |
Contributor
There was a problem hiding this comment.
issue: Toast title is hard-coded and inconsistent
The success and error toasts use different titles ('Pdf Viewer' vs. 'PdfViewer'). Please standardize and consider localizing the title for consistency.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6170 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 704 704
Lines 31099 31099
Branches 4394 4394
=========================================
Hits 31099 31099
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #6169
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Introduce a new UseGoogleDocs parameter to the PdfViewer component and update the sample to include a toggle for this option.
New Features: