Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Jun 6, 2025

Link issues

fixes #6171

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Fix the Select component's search icon alignment in the BI icon theme and update the PDF viewer sample default behavior

Bug Fixes:

  • Vertically center the search icon in the Select dropdown by adding flex centering and adjusting the top offset variable

Enhancements:

  • Change the PDF viewer sample to disable Google Docs view by default

@bb-auto bb-auto bot added the bug Something isn't working label Jun 6, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jun 6, 2025

Reviewer's Guide

This PR fixes the vertical misalignment of the search icon in the Select component under the BI icon theme by enhancing its styles with explicit sizing and flex centering, and it also updates the default Google Docs flag in the PdfViewer sample from true to false.

File-Level Changes

Change Details Files
Center search icon in Select component
  • Added width and height of 1rem to the search icon container
  • Applied display:flex with align-items and justify-content center
  • Adjusted vertical offset CSS variable from 19px to 18px
src/BootstrapBlazor/Components/Select/Select.razor.scss
src/BootstrapBlazor/wwwroot/scss/theme/bootstrapblazor.scss
Update default PDF viewer setting
  • Changed _useGoogleDocs flag default from true to false
src/BootstrapBlazor.Server/Components/Samples/PdfViewers.razor.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#6171 The search icon in the Select component should be vertically centered when using the BI icon theme.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added this to the 9.7.0 milestone Jun 6, 2025
@ArgoZhang ArgoZhang merged commit ac65287 into main Jun 6, 2025
3 checks passed
@ArgoZhang ArgoZhang deleted the refactor-pdf branch June 6, 2025 07:52
@ArgoZhang ArgoZhang changed the title fix(Selelct): search icon not vertical center when use BI icon theme fix(Select): search icon not vertical center when use BI icon theme Jun 6, 2025
@ArgoZhang ArgoZhang restored the refactor-pdf branch June 6, 2025 07:52
@codecov
Copy link

codecov bot commented Jun 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c507f68) to head (d46a12f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6172   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          704       704           
  Lines        31099     31099           
  Branches      4394      4394           
=========================================
  Hits         31099     31099           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ArgoZhang ArgoZhang deleted the refactor-pdf branch June 6, 2025 07:53
@ArgoZhang ArgoZhang restored the refactor-pdf branch June 6, 2025 07:54
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

  • Remove the stray BOM/zero-width character before the ".select" selector in Select.razor.scss to avoid CSS parsing issues.
  • Extract the hardcoded 1rem icon width/height values into a SCSS variable (e.g. $bb-select-search-icon-size) to keep sizing configurable and consistent across themes.
  • Add a visual regression or snapshot test for the Select component’s search icon alignment in the BI icon theme to catch future misalignment issues.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@@ -1,4 +1,4 @@
.select,
.select,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): Remove invisible BOM character at start of line

The BOM character before .select may cause Sass parsing errors. Please remove it to ensure correct selector parsing.

@ArgoZhang ArgoZhang deleted the refactor-pdf branch June 6, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(Select): search icon not vertical center when use BI icon theme

2 participants