-
-
Notifications
You must be signed in to change notification settings - Fork 363
fix(Select): search icon not vertical center when use BI icon theme #6172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis PR fixes the vertical misalignment of the search icon in the Select component under the BI icon theme by enhancing its styles with explicit sizing and flex centering, and it also updates the default Google Docs flag in the PdfViewer sample from true to false. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6172 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 704 704
Lines 31099 31099
Branches 4394 4394
=========================================
Hits 31099 31099
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
- Remove the stray BOM/zero-width character before the ".select" selector in Select.razor.scss to avoid CSS parsing issues.
- Extract the hardcoded 1rem icon width/height values into a SCSS variable (e.g. $bb-select-search-icon-size) to keep sizing configurable and consistent across themes.
- Add a visual regression or snapshot test for the Select component’s search icon alignment in the BI icon theme to catch future misalignment issues.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| @@ -1,4 +1,4 @@ | |||
| .select, | |||
| .select, | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (bug_risk): Remove invisible BOM character at start of line
The BOM character before .select may cause Sass parsing errors. Please remove it to ensure correct selector parsing.
Link issues
fixes #6171
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Fix the Select component's search icon alignment in the BI icon theme and update the PDF viewer sample default behavior
Bug Fixes:
Enhancements: