Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Jun 10, 2025

Link issues

fixes #6196

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Improve exception messaging and naming consistency by refining BootstrapServiceBase error handling and renaming computed properties in BootstrapBlazorRoot.

Enhancements:

  • Enhance exception handling in BootstrapServiceBase by consolidating message construction, appending Chinese guidance, and updating tuple deconstruction to use a lowercase callback variable
  • Rename private computed properties in BootstrapBlazorRoot from underscore-prefixed fields to CamelCase (EnableErrorLoggerValue and ShowToastValue)
  • Update Razor component to use the renamed properties for error logger configuration

@bb-auto bb-auto bot added the enhancement New feature or request label Jun 10, 2025
@bb-auto bb-auto bot added this to the 9.7.0 milestone Jun 10, 2025
@ArgoZhang ArgoZhang merged commit 7ba4e74 into main Jun 10, 2025
3 checks passed
@ArgoZhang ArgoZhang deleted the refactor-root branch June 10, 2025 06:44
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jun 10, 2025

Reviewer's Guide

This PR enhances exception messaging in BootstrapServiceBase by introducing bilingual guidance and refactors callback handling, while also renaming internal members in BootstrapBlazorRoot for consistency and updating its Razor markup accordingly.

Updated Class Diagram for BootstrapServiceBase and BootstrapBlazorRoot

classDiagram
  class BootstrapServiceBase~TOption~ {
    #Invoke(TOption option, ComponentBase? component) Task
    %% Method modified: updated exception message, local var 'Callback' to 'callback', unused 'Key' to '_' %%
  }

  class BootstrapBlazorRoot {
    %% --- Old private properties (removed) --- %%
    %% -_enableErrorLoggerValue: bool %%
    %% -_showToast: bool %%

    %% --- New private properties (renamed) --- %%
    -EnableErrorLoggerValue: bool
    -ShowToastValue: bool
  }
Loading

File-Level Changes

Change Details Files
Enhanced exception handling and callback invocation in Invoke method
  • Renamed tuple destructuring variables to (_, callback)
  • Introduced a 'message' variable containing bilingual guidance based on target framework
  • Replaced direct exception throw with throw using the 'message' variable
  • Updated callback invocation from Callback.Invoke(option) to callback(option)
src/BootstrapBlazor/Services/BootstrapServiceBase.cs
Renamed internal members and updated Razor component parameters
  • Converted private fields _enableErrorLoggerValue and _showToast into properties EnableErrorLoggerValue and ShowToastValue
  • Updated ErrorLogger component attributes to reference the new property names
src/BootstrapBlazor/Components/BaseComponents/BootstrapBlazorRoot.razor.cs
src/BootstrapBlazor/Components/BaseComponents/BootstrapBlazorRoot.razor

Assessment against linked issues

Issue Objective Addressed Explanation
#6196 Update the exception message in BootstrapServiceBase to provide more context and guidance to the user.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@codecov
Copy link

codecov bot commented Jun 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6549430) to head (6991739).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6197   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          704       704           
  Lines        31099     31100    +1     
  Branches      4394      4394           
=========================================
+ Hits         31099     31100    +1     
Flag Coverage Δ
BB 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(BootstrapServiceBase): update exception message

2 participants