Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Jun 11, 2025

Link issues

fixes #6204

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Revert dynamic loading of the Bootstrap Blazor bundle from individual component scripts and restore a single static script include for the bootstrap.blazor.bundle.min.js file.

Bug Fixes:

Enhancements:

  • Remove dynamic import statements for bootstrap.blazor.bundle.min.js from all component JS modules.
  • Add a static <script> tag for bootstrap.blazor.bundle.min.js in the main App.razor page to ensure the bundle is loaded before component scripts.

@bb-auto bb-auto bot added the enhancement New feature or request label Jun 11, 2025
@bb-auto bb-auto bot added this to the 9.7.0 milestone Jun 11, 2025
@codecov
Copy link

codecov bot commented Jun 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a828f38) to head (1270d85).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6205   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          704       704           
  Lines        31100     31100           
  Branches      4394      4394           
=========================================
  Hits         31100     31100           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ArgoZhang ArgoZhang changed the title chore(Bootstrap): fix missing bootstrap.blazor.bundle.min.js revert(Bootstrap): revert dynamic load bootstrap module Jun 11, 2025
@ArgoZhang ArgoZhang merged commit f94e3c0 into main Jun 11, 2025
3 checks passed
@ArgoZhang ArgoZhang deleted the fix-js branch June 11, 2025 05:06
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

revert(Bootstrap): revert dynamic load bootstrap module

2 participants